feat(workflows): add tags #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Your org requires the Graphite merge queue for merging into mainYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
Contributor
Author
This was referenced Jun 27, 2024
MasterPtato
force-pushed
the
06-26-feat_workflows_add_tags
branch
from
67c76a6 to
53760a1
Compare
This was referenced Jul 2, 2024
MasterPtato
force-pushed
the
06-26-feat_workflows_add_tags
branch
2 times, most recently
from
050db41 to
b0e67b0
Compare
AngelOnFira
reviewed
Jul 8, 2024
This was referenced Jul 11, 2024
This was referenced Jul 19, 2024
MasterPtato
force-pushed
the
06-26-feat_workflows_add_tags
branch
from
b0e67b0 to
64339ff
Compare
This was referenced Jul 24, 2024
Merged
This was referenced Jul 30, 2024
MasterPtato
force-pushed
the
06-26-feat_workflows_add_tags
branch
from
64339ff to
59f82b4
Compare
This was referenced Jul 31, 2024
NathanFlurry
approved these changes
Aug 2, 2024
Contributor
Merge activity
|
<!-- Please make sure there is an issue that this PR is correlated to. -->
## TLDR
- Tags are a json blob attached to workflows
- Tags are optional
- When publishing a signal with tags, it will be consumed by any workflow with a superset of the signals own tags:
- a workflow with tags `{ "foo": 1, "bar": ["a"] }` will consume a signal with tags `{ "bar": ["a"] }`
- While any json is allowed, i assume CRDB JSON comparison queries perform better when its plain string comparison
## Changes
<!-- If there are frontend changes, please include screenshots. -->
NathanFlurry
force-pushed
the
06-26-feat_workflows_add_tags
branch
from
59f82b4 to
36494eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
{ "foo": 1, "bar": ["a"] }will consume a signal with tags{ "bar": ["a"] }Changes