fix(cf): remove asynclocalstorage dep

[jog1t]

No description provided.

[claude]

Claude finished @jog1t's task —— View job

---

Code Review Complete ✅

I've analyzed this pull request that removes AsyncLocalStorage dependency from the Cloudflare Workers driver.

Tasks:

• Read and analyze the modified files
• Understand the AsyncLocalStorage removal impact
• Review code quality and identify potential issues
• Check for performance and security considerations
• Evaluate test coverage needs
• Provide comprehensive feedback

Changes Analysis

The PR removes the AsyncLocalStorage pattern used in the Cloudflare Workers driver and simplifies the ambient environment access. Key changes:

1. Removed AsyncLocalStorage pattern: CF_AMBIENT_ENV (AsyncLocalStorage) replaced with direct env import
2. Simplified environment access: getCloudflareAmbientEnv() now directly returns env as unknown as Bindings
3. Removed wrapper calls: All CF_AMBIENT_ENV.run() calls removed from initialize(), fetch(), and alarm() methods
4. Dependency cleanup: Removed node:async_hooks import and invariant usage

Review Feedback

✅ Positive Changes

• Cleaner code: Removed complex AsyncLocalStorage wrapper pattern
• Better performance: Direct access to env eliminates context switching overhead
• Cloudflare-native: Uses the official env global from cloudflare:workers runtime
• Consistent pattern: More aligned with standard Cloudflare Workers development practices

⚠️ Potential Issues

1. Breaking change for manager-driver: The getCloudflareAmbientEnv() function is still used in manager-driver.ts (6 locations). This change may break the manager driver functionality since it now returns env as unknown as Bindings instead of the context-specific environment.

2. Stale comment: In handler.ts:23, the comment still references the old pattern:

   // Use getCloudflareAmbientEnv unless using CF_AMBIENT_ENV.run.

3. Type safety concern: Using env as unknown as Bindings bypasses TypeScript's type checking, though this appears to be necessary for the Cloudflare runtime.

🔧 Recommended Fixes

1. Update the comment in handler.ts:23 to reflect the new usage pattern
2. Verify manager-driver compatibility: Ensure that manager-driver.ts works correctly with the simplified getCloudflareAmbientEnv() function
3. Consider adding tests: Verify that the environment is accessible in all contexts where getCloudflareAmbientEnv() is called

🚀 Performance & Security

• Performance improvement: Removing AsyncLocalStorage eliminates context switching overhead
• Security: No security concerns identified - the change maintains the same access patterns to environment variables

🧪 Test Coverage

The existing test files don't appear to directly test the AsyncLocalStorage pattern, so this change shouldn't break existing tests. However, integration tests should verify that environment access works correctly in all contexts.

Conclusion

This is a well-motivated change that simplifies the codebase and improves performance. The main concern is ensuring compatibility with the manager driver. Consider testing the full request lifecycle to ensure getCloudflareAmbientEnv() works correctly in all calling contexts.

[jog1t]

• fix(cf): remove asynclocalstorage dep #1157 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[pkg-pr-new]

More templates

• example-ai-agent
• example-better-auth-external-db
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• counter
• example-crdt
• example-database
• example-sqlite
• example-elysia
• example-express
• example-game
• example-hono
• example-hono-react
• example-next-js
• example-rate
• example-raw-fetch-handler
• example-raw-websocket-handler-proxy
• example-react
• example-redis
• example-redis-hono
• starter
• example-stream
• example-sync
• example-tenant
• example-trpc

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/actor@1157

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/core@1157

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/db@1157

rivetkit

pnpm add https://pkg.pr.new/rivet-gg/rivetkit@1157

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/cloudflare-workers@1157

@rivetkit/redis

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/redis@1157

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/framework-base@1157

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/next-js@1157

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/react@1157

commit: 679bbde

[graphite-app]

Merge activity

• Aug 8, 8:48 PM UTC: jog1t added this pull request to the Graphite merge queue.
• Aug 8, 8:48 PM UTC: CI is running for this pull request on a draft pull request (#1159) due to your merge queue CI optimization settings.
• Aug 8, 8:49 PM UTC: Merged by the Graphite merge queue via draft PR: #1159.