chore(core): reduce dupe action request schema validation

[NathanFlurry]

No description provided.

[claude]

Claude finished @NathanFlurry's task —— View job

---

Code Review for PR #1168 - "chore(core): reduce dupe action request schema validation"

Todo List

• Read and analyze the changed file (packages/core/src/actor/router-endpoints.ts)
• Review code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Assess security concerns
• Review test coverage implications
• Provide comprehensive feedback

Summary

This PR refactors the handleAction function in router-endpoints.ts:416-518 to eliminate duplicate schema validation by consolidating the parsing and validation logic. The change reduces code duplication and improves maintainability.

Code Quality & Best Practices ✅

Positive Changes:

• DRY Principle: Successfully eliminates duplicate ActionRequestSchema.safeParse() calls that were previously executed in both JSON and CBOR branches
• Clear Separation of Concerns: Better separation between data parsing/deserialization and schema validation
• Consistent Error Handling: Improved error messages with more specific context (e.g., "Invalid JSON: ..." vs generic "Invalid JSON")

Code Structure Improvement:

• The refactored code follows a cleaner pattern: parse → validate → execute
• More consistent error message formatting using stringifyError(err)

Potential Issues & Bugs 🔍

No Critical Issues Found:

• The refactoring maintains identical functional behavior
• Error handling paths are preserved and improved
• All edge cases appear to be handled correctly

Minor Observation:

• The intermediate body variable adds a small memory overhead, but this is negligible and worth the code clarity gained

Performance Considerations ⚡

Improvements:

• Reduced Duplicate Validation: Previously, schema validation was duplicated in both encoding branches. Now it's executed only once after parsing
• Slight Performance Gain: Eliminates redundant ActionRequestSchema.safeParse() calls

Impact: Minimal but positive performance improvement for action requests.

Security Concerns 🔒

No Security Issues:

• All existing input validation remains intact
• Schema validation still occurs before processing action arguments
• Error handling doesn't expose sensitive information
• The refactoring doesn't introduce any new attack vectors

Test Coverage 📋

Observation:

• No dedicated test files found for router-endpoints.ts functionality
• The ActionRequestSchema is used across multiple files (router.ts, etc.) suggesting integration testing may cover this functionality
• Recommendation: Consider adding unit tests specifically for handleAction to cover:
  • JSON parsing edge cases
  • CBOR deserialization edge cases
  • Schema validation failures
  • Error message formatting

Overall Assessment ✅

This is a well-executed refactoring that:

• Reduces code duplication
• Improves maintainability
• Slightly enhances performance
• Maintains all existing functionality and error handling
• Follows good coding practices

Recommendation: Approve - This change makes the codebase cleaner and more maintainable without introducing any risks.

[NathanFlurry]

• fix(core): disable body parsing on HonoOpenAPI to fix JSON protocol #1169
• chore(core): reduce dupe action request schema validation #1168 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Merge activity

• Aug 9, 1:35 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
• Aug 9, 1:36 AM UTC: CI is running for this pull request on a draft pull request (#1170) due to your merge queue CI optimization settings.
• Aug 9, 1:37 AM UTC: Merged by the Graphite merge queue via draft PR: #1170.

[pkg-pr-new]

More templates

• example-ai-agent
• example-better-auth-external-db
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• counter
• example-crdt
• example-database
• example-sqlite
• example-elysia
• example-express
• example-game
• example-hono
• example-hono-react
• example-next-js
• example-rate
• example-raw-fetch-handler
• example-raw-websocket-handler-proxy
• example-react
• example-redis
• example-redis-hono
• starter
• example-stream
• example-sync
• example-tenant
• example-trpc

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/actor@1168

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/core@1168

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/db@1168

rivetkit

pnpm add https://pkg.pr.new/rivet-gg/rivetkit@1168

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/cloudflare-workers@1168

@rivetkit/redis

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/redis@1168

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/framework-base@1168

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/next-js@1168

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/react@1168

commit: 6e628c8