fix(core): revert deleted fixtures

[NathanFlurry]

No description provided.

[claude]

Claude finished @NathanFlurry's task —— View job

---

PR Review: Revert Deleted Fixtures ✅

Todo List:

• Analyze the overall structure and purpose of the fixture files
• Review code quality and TypeScript best practices
• Check for security concerns in test fixtures
• Evaluate test coverage and completeness
• Look for potential bugs or issues
• Assess performance considerations
• Provide constructive feedback and recommendations

Review Summary

This PR restores 22 comprehensive test fixture files that form a robust driver test suite. Overall, the fixtures are well-implemented and follow RivetKit patterns consistently. Here are my findings:

✅ Strengths

Code Quality & Best Practices

• Consistent API usage: All fixtures properly use the @rivetkit/core actor API
• TypeScript typing: Good use of types, including proper ActorContext typing in raw-http.ts:13-14 and raw-websocket.ts:2-4
• Error handling: Proper use of UserError for client-facing errors throughout auth fixtures
• State management: Clean separation of actor state, connection state, and variables

Test Coverage

• Comprehensive scenarios: Covers authentication patterns, WebSocket/HTTP handling, scheduling, error cases, timeouts
• Edge cases: Includes void return handling (raw-http.ts:75), binary WebSocket data, custom timeouts
• Auth variations: Tests public access, required auth, intent-based permissions, async auth

Security Implementation

• Proper error types: Uses UserError consistently for auth failures instead of exposing internal errors
• Test credentials: Hardcoded credentials like "valid-api-key" are appropriate for test fixtures
• Auth patterns: Demonstrates both onAuth and custom request-level authentication

⚠️ Minor Issues Found

TypeScript & Code Quality

1. Inconsistent typing in raw-websocket.ts:102 and similar locations:

   // Current - overly permissive
   actions: { getStats(ctx: any) { ... } }
   
   // Better - use proper actor context typing
   actions: { getStats(c) { ... } }

2. Console.log statements should be removed for production:

   • auth.ts:31: console.log("intents", intents, params);
   • Multiple debug logs in raw-websocket.ts

Potential Improvements

1. Error handling in WebSocket parsing: Some fixtures have empty catch blocks (raw-websocket.ts:83) - consider logging parse errors for debugging

2. Magic numbers: Consider constants for timeout values (action-timeout.ts:9, error-handling.ts:74)

3. State mutation in tests: vars.ts:38-40 modifies nested objects - ensure this is intentional test behavior

🔍 No Critical Issues

• No security vulnerabilities found
• No memory leaks or performance concerns
• No malicious code detected
• Test isolation appears proper

Recommendation

✅ APPROVE - This is a solid restoration of test fixtures with only minor cosmetic improvements needed. The fixtures provide excellent coverage for driver testing and follow established patterns well.

Optional follow-up improvements:

• Remove console.log statements for cleaner test output
• Consider using typed actor contexts instead of any types
• Add constants for magic timeout values

The restored fixtures will significantly improve the driver test suite reliability.

---

[NathanFlurry]

• chore: simplify package directories #1205
• chore(core): migrate actor persist & file system to bare #1204
• chore(core): migrate client protocol to BARE #1203
• chore(core): move actor liveness check to setInterval #1202
• fix(core): fix disconnecting sse connections #1201
• feat(core): add abort controller & implement waitUntil #1200
• feat(core): actor sleeping #1178
• fix(core): revert deleted fixtures #1199 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[pkg-pr-new]

More templates

• example-ai-agent
• example-better-auth-external-db
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• counter
• example-crdt
• example-database
• example-sqlite
• example-elysia
• example-express
• example-game
• example-hono
• example-hono-react
• example-next-js
• example-rate
• example-raw-fetch-handler
• example-raw-websocket-handler-proxy
• example-react
• starter
• example-stream
• example-sync
• example-tenant
• example-trpc

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/actor@1199

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/core@1199

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/db@1199

rivetkit

pnpm add https://pkg.pr.new/rivet-gg/rivetkit@1199

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/cloudflare-workers@1199

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/framework-base@1199

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/next-js@1199

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-gg/rivetkit/@rivetkit/react@1199

commit: 779f5ae

[graphite-app]

Merge activity

• Sep 11, 10:34 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
• Sep 11, 10:35 PM UTC: CI is running for this pull request on a draft pull request (#1206) due to your merge queue CI optimization settings.
• Sep 11, 10:35 PM UTC: Merged by the Graphite merge queue via draft PR: #1206.