Skip to content

Conversation

@theouteredge
Copy link
Contributor

Just adding a simple Count function which allows you to count how many items in a slice match the predicate you specify

Created a Tuple struct as some of the new functions require you to return a new slice with two fields which is the result of the new functions

Created the Join, JoinProjection, Range, SumMap, Zip functions, ecah fuction is documented with how it works and had a unit test or maybe more
Updated the comments on the Join & OrderBy functions so they make a little more sense.

Covered an extra test case with the Join test, where the left set has more data than the right and so the Right handside array of the join is empty
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #34 (b1cb789) into main (0bc3a54) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   99.19%   99.21%   +0.02%     
==========================================
  Files          29       30       +1     
  Lines         247      254       +7     
==========================================
+ Hits          245      252       +7     
  Misses          2        2              
Flag Coverage Δ
unittests 99.21% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
count.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@rjNemo rjNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice.
Thanks!

@rjNemo rjNemo merged commit 291df4f into rjNemo:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants