Skip to content

Constructor inheritance #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 2, 2020
Merged

Constructor inheritance #15

merged 10 commits into from
Jul 2, 2020

Conversation

@aminya
Copy link
Collaborator

@aminya aminya commented Jul 1, 2020 •
edited
Loading

super constructor inheritance when the child does not have any additional fields

@class Animal begin
    x
    Animal(x, y) = new(x)
end

function Animal(x, y, z)
    return Animal(x+y+z)
end

@class Dog <: Animal begin
end

Dog(1,2)
Dog(1,2,3)

@aminya aminya force-pushed the constructor_inheritance branch 2 times, most recently from 9569d29 to 4dd7dea Compare July 1, 2020 14:45
@aminya aminya force-pushed the constructor_inheritance branch from 4dd7dea to d9e522e Compare July 2, 2020 01:41
aminya added 7 commits July 2, 2020 01:06
@aminya
super_constructor_inheritance with parameters
3617fbb
@aminya
super constructor inheritance with parameters test
76d4fc6
@aminya
fieldless class with parameters test
57d1ac4
@aminya
[skip ci] Add examples to the readme
f42fddf
@aminya
Don't collect generators for speed
072348a
@aminya
using broadcast instead of generator [speed]
cbab46f 
benchmark:
```julia
using Classes
using BenchmarkTools
struct Foo{T}
    x::T
    y::T
    z::T
end

f = Foo(1,2,3)

fnames = [:x, :y, :z]

function t1(f, fnames)
    x = (getfield(f, arg) for arg in fnames)
    return Foo(x...)
end

x = @Btime t1($f, $fnames)

function t2(f, fnames)
    x = getfield.(Ref(f), fnames)
    return Foo(x...)
end

x = @Btime t2($f, $fnames)

```
@aminya
allow_failures julia 1.0
86a48c7
@aminya aminya force-pushed the constructor_inheritance branch from 384442d to 86a48c7 Compare July 2, 2020 06:34
@aminya aminya merged commit 3cbb6c1 into rjplevin:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aminya