Skip to content

Conversation

@github-actions
Copy link
Contributor

This pull request changes the compat entry for the DataStructures package from 0.17 to 0.17, 0.18.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@lrennels
Copy link
Collaborator

@rjplevin would it be possible to merge this? It's causing some compatibility issues for Mimi models, thank you so much!

@aminya aminya closed this Apr 29, 2021
@aminya aminya reopened this Apr 29, 2021
@aminya aminya merged commit 38efa25 into master Apr 29, 2021
@aminya aminya deleted the compathelper/new_version/2020-08-18-01-07-45-394-3481582331 branch April 29, 2021 05:44
@lrennels
Copy link
Collaborator

wow @aminya that was fast!! a patch release would also be great if possible just to keep the [compat] story clean on our packages, but if that's not possible just let me know and I can try to get around it

@aminya
Copy link
Collaborator

aminya commented Apr 29, 2021

@lrennels You're welcome! I made a new release. You can track its release progress here:
JuliaRegistries/General#35619

if possible just to keep the [compat] story clean on our packages, but if that's not possible just let me know and I can try to get around it

I can relax the bounds if that helps.

@lrennels
Copy link
Collaborator

I think we just need v0.18 to be included, it's because one of our users is also trying to use a package with really tight compat bounds that require v0.18 ... I'll let you know if this doesn't work thanks so much

@lrennels
Copy link
Collaborator

lrennels commented Apr 29, 2021

once it gets tagged in the registry I'll try setting up their environment again and I think things should flow through ok, but will ping you if they don't :) , I'll just wait for the TagBot to work it's fancy magic (or for you to tag) so Julia Pkg manager picks up v1.4.1

@aminya
Copy link
Collaborator

aminya commented Apr 29, 2021

I made a new GitHub tag. I think it should work now. Try it and let me know how it goes!

@lrennels
Copy link
Collaborator

Perfect I think we're set ... still seeing issues but they're upstream of you so thanks for your help!!

@aminya
Copy link
Collaborator

aminya commented Apr 29, 2021

You're welcome! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants