Allow to be consumed without use_frameworks! #714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mfazekas
changed the title
Contributor
|
Tested it and it worked on my side. That's really great, I ship it to production :D |
Contributor
|
Hi @mfazekas, I also ran this through on our end. This appears to be working. App also ran successfully.
|
Contributor
|
@mfazekas Thank you for your work on this PR. Very much appreciated!! |
Contributor
Author
|
Probably i'd rename the podspec to
|
Contributor
|
@mfazekas that sounds good to me. Good and clear. |
mfazekas
force-pushed
the
allow-no-use-frameworks
branch
from
ec0eba8 to
f2a1fd6
Compare
mfazekas
changed the title
|
Tested and working ! Thanks a lot @mfazekas ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible workaround for
use_frameworks!If you don't want
use_frameworks!in your podfile use thepod 'NoUseFrameworks-MapboxMobileEvents' ...line bellow:Note: you can test this PR with this in your packages.json
"@react-native-mapbox-gl/maps": "mfazekas/maps-1#allow-no-use-frameworks"
See mapbox/mapbox-gl-native-ios#154