Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
126 commits
Select commit Hold shift + click to select a range
cdbafe6
Clean up warnings
naftalibeder Apr 18, 2022
b0b0793
Remove log
naftalibeder Apr 18, 2022
6fcaa7e
Listen for and return map drag information in callbacks
naftalibeder Apr 19, 2022
4e14afd
Add example showing map gesture handling
naftalibeder Apr 19, 2022
c47fbd6
Remove unneeded enum string values
naftalibeder Apr 19, 2022
de50625
Add new region callbacks to mirror v10 native API
naftalibeder Apr 19, 2022
9748f80
Display additional callback info
naftalibeder Apr 19, 2022
ecf6048
Use instant camera transition
naftalibeder Apr 19, 2022
9fd16b0
Add long-press handler
naftalibeder Apr 19, 2022
054cf0a
Incorporate tap and long-press into example
naftalibeder Apr 19, 2022
eea4150
Merge branch 'main' of github.com:rnmapbox/maps into feat/callbacks
naftalibeder Apr 19, 2022
a31cc0d
Ignore Ruby gems and local bundler files, cleanup
naftalibeder Apr 20, 2022
ea49f0c
Merge branch 'feat/map' into staging
naftalibeder Apr 20, 2022
275e09b
Merge branch 'fix/ignore' into staging
naftalibeder Apr 20, 2022
9b9786c
Merge branch 'main' of github.com:rnmapbox/maps into staging
naftalibeder Apr 20, 2022
f92948c
Merge branch 'feat/map' into staging
naftalibeder Apr 20, 2022
d04a035
Merge branch 'feat/map' into staging
naftalibeder Apr 20, 2022
65604b2
Merge branch 'fix/layer' into staging
naftalibeder Apr 21, 2022
0ce19e4
Merge branch 'main' of github.com:rnmapbox/maps into staging
naftalibeder Apr 22, 2022
14fb676
Merge branch 'feat/map' into staging
naftalibeder Apr 22, 2022
22bc2af
Merge branch 'fix/layer' into staging
naftalibeder Apr 22, 2022
90d67bc
Merge branch 'main' of github.com:rnmapbox/maps into staging
naftalibeder Apr 25, 2022
9ab7777
Merge branch 'main' of github.com:rnmapbox/maps into staging
naftalibeder Apr 27, 2022
0c258b8
Convert Camera to typescript
naftalibeder Apr 27, 2022
fefa4dd
Fix import
naftalibeder Apr 27, 2022
4d74a6c
Clean up and expand stop methods
naftalibeder Apr 27, 2022
232ec86
Add memoization
naftalibeder Apr 27, 2022
8d649ae
Rename
naftalibeder Apr 27, 2022
42e36df
Build out primary imperative camera method
naftalibeder Apr 27, 2022
62cb579
Implement imperative methods, refactor and expand types
naftalibeder Apr 28, 2022
3e0b987
Update camera imports and exports
naftalibeder Apr 28, 2022
7682ee4
Refactor and add types
naftalibeder Apr 28, 2022
7353412
Clean up
naftalibeder Apr 28, 2022
7f1df7d
Remove log
naftalibeder Apr 28, 2022
1c3297d
Provide camera ref types and comments
naftalibeder Apr 28, 2022
6c4decd
Fix zoom force unwrap potential crash
naftalibeder Apr 28, 2022
18c974e
Add ref to exports
naftalibeder Apr 28, 2022
7429ff8
Expand to include imperative methods
naftalibeder Apr 28, 2022
0995faa
Merge branch 'main' of github.com:rnmapbox/maps into chore/camera
naftalibeder Apr 28, 2022
84a5469
Convert to typescript, simplify export shape, alter camera type exports
naftalibeder Apr 28, 2022
bfe8dcf
Export prop types
naftalibeder Apr 28, 2022
3407291
Use updated import shape
naftalibeder Apr 28, 2022
7ac1c89
Merge branch 'chore/camera' into staging
naftalibeder Apr 28, 2022
21e9fa9
Cleanup
naftalibeder Apr 28, 2022
ea8a675
Refactor index and definitions files to correctly export all types
naftalibeder Apr 28, 2022
748c78f
Fix exports to allow access to .d.ts types
naftalibeder Apr 29, 2022
c243718
Re-export .d.ts types
naftalibeder Apr 29, 2022
7d3793f
Move definitions file back to javascript folder
naftalibeder Apr 29, 2022
d881830
Refactor and distinguish exports as components, types, etc.
naftalibeder Apr 29, 2022
e00bfbf
Export type, rename
naftalibeder Apr 29, 2022
74fd2a0
Fix buggy reference
naftalibeder Apr 29, 2022
20f86d1
Update .d.ts file name
naftalibeder Apr 29, 2022
0d9dc7d
Look for types
naftalibeder Apr 29, 2022
3681b2d
Remove seemingly erroneous file copy
naftalibeder Apr 29, 2022
202d031
Fix default export typing
naftalibeder Apr 29, 2022
069a9ac
Remove unused file
naftalibeder Apr 29, 2022
418b1c3
Add additional class exports
naftalibeder Apr 29, 2022
4a21c6b
Rename variable
naftalibeder Apr 29, 2022
7a18804
Fix import and expected keys
naftalibeder Apr 29, 2022
e4257e5
Fix test imports
naftalibeder Apr 29, 2022
51893c4
Merge branch 'main' of github.com:rnmapbox/maps into chore/camera
naftalibeder May 6, 2022
f5202d2
Update doc generator to handle ts files, add documentation
naftalibeder May 6, 2022
9013a67
Add initial tests for new Camera functional component
naftalibeder May 6, 2022
f3bf118
Update docs with edited autogenerated comment
naftalibeder May 6, 2022
c1b20d3
Merge branch 'main' of github.com:rnmapbox/maps into chore/camera
naftalibeder May 11, 2022
f98f8c2
Remove ts file from exported definitions
naftalibeder May 11, 2022
3787931
Fix replace method bug
naftalibeder May 11, 2022
9a79894
Add doc comment
naftalibeder May 11, 2022
9de43cc
Merge branch 'main' of github.com:rnmapbox/maps into chore/camera
naftalibeder May 12, 2022
81916d0
Include methods in functional component docs output
naftalibeder May 12, 2022
b7a0a30
Document methods and improve description
naftalibeder May 12, 2022
09bacc1
Merge branch 'main' of github.com:rnmapbox/maps into chore/camera
naftalibeder May 13, 2022
14dbebb
Refactor .d.ts files and imports
naftalibeder May 16, 2022
ccbb956
Merge branch 'main' of github.com:rnmapbox/maps into chore/camera
naftalibeder May 16, 2022
51e3cef
Reorganize Camera types
naftalibeder May 16, 2022
1568b2e
Fix imports
naftalibeder May 16, 2022
688de76
Fix animationMode returns and add test
naftalibeder May 16, 2022
3bdd44a
Refactor camera types for docs purposes
naftalibeder May 16, 2022
aeb7ca9
Reimplement allowUpdates
naftalibeder May 16, 2022
1f57041
Fix exported types namespace
naftalibeder May 16, 2022
0c86521
Set up example as ts project
naftalibeder May 16, 2022
b248286
Fix types paths
naftalibeder May 16, 2022
2c6e1bb
Ignore example project
naftalibeder May 17, 2022
28871a0
Upgrade types
naftalibeder May 17, 2022
3ceeea6
Fix paths, remove unused
naftalibeder May 17, 2022
c725179
Expand and fix types
naftalibeder May 17, 2022
a1b5c07
Remove lib before rebuilding
naftalibeder May 17, 2022
40e666d
Edit types
naftalibeder May 17, 2022
1962e38
Adjust build flow
naftalibeder May 17, 2022
6d498be
Fix build
naftalibeder May 17, 2022
a80a9a3
Fix imports
naftalibeder May 17, 2022
68fb18e
Include lib dir
naftalibeder May 17, 2022
96d189d
Fix glob
naftalibeder May 17, 2022
9a3f1f2
Add dir
naftalibeder May 17, 2022
170c8ac
Don't compile output files
naftalibeder May 17, 2022
83db657
Ignore output of npm pack
naftalibeder May 18, 2022
c913bf7
Update included files and eslint plugin
naftalibeder May 18, 2022
94fe97f
Fix import
naftalibeder May 18, 2022
6d58980
Fix imports
naftalibeder May 18, 2022
411793a
Merge branch 'main' of github.com:rnmapbox/maps into chore/camera
naftalibeder May 18, 2022
02ea695
Add podspec path to instructions
naftalibeder May 18, 2022
24cf619
Cleanup
naftalibeder May 18, 2022
d278889
Use unpacked parent dir
naftalibeder May 18, 2022
fec8430
Reference Camera directly
naftalibeder May 18, 2022
966f954
Merge pull request #1872 from TruckMap/chore/camera
naftalibeder May 19, 2022
7d95ab3
Fix declarations and imports
naftalibeder May 24, 2022
0962134
Remove jsdoc declaration from doc generation
naftalibeder May 24, 2022
002c0ae
Merge branch 'main' of github.com:rnmapbox/maps into chore/typescript
naftalibeder May 24, 2022
4c1a3e5
Fix linter
naftalibeder May 24, 2022
1276fb4
Apply autoformat fixes
naftalibeder May 24, 2022
d55297a
Fix Animated* types
naftalibeder May 24, 2022
a828c28
Merge pull request #1928 from TruckMap/chore/typescript
naftalibeder May 24, 2022
1f44159
Add compiling information
naftalibeder May 24, 2022
c8fe0dc
Merge pull request #1929 from TruckMap/chore/typescript
naftalibeder May 24, 2022
0c5a3e9
Compile lib in prepare step
naftalibeder May 24, 2022
49eec98
Add try/catch
naftalibeder May 24, 2022
57430a3
Call only needed commands
naftalibeder May 24, 2022
e68e1d4
Merge pull request #1931 from TruckMap/chore/typescript
naftalibeder May 24, 2022
e49e75f
Merge branch 'main' of github.com:rnmapbox/maps into chore/typescript
naftalibeder May 27, 2022
ec3756e
Merge branch 'main' of github.com:rnmapbox/maps into chore/typescript
naftalibeder May 27, 2022
0a209ba
Merge branch 'main' of github.com:rnmapbox/maps into chore/typescript
naftalibeder Jun 8, 2022
02fda84
Merge branch 'main' of github.com:rnmapbox/maps into chore/typescript
naftalibeder Jun 10, 2022
9574fad
Update build scripts
naftalibeder Jun 10, 2022
c9fed9d
Merge pull request #1977 from rnmapbox/main
naftalibeder Jun 10, 2022
8aaee96
Merge branch 'chore/typescript' of github.com:rnmapbox/maps into chor…
naftalibeder Jun 10, 2022
c7151de
Merge pull request #1978 from TruckMap/chore/typescript
naftalibeder Jun 10, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
/plugin/build
plugin
example
lib
__tests__
ios/RCTMGL/index.d.ts
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = {
root: true,
parser: 'babel-eslint',
parser: '@babel/eslint-parser',
plugins: ['react', 'react-native', 'fp', 'import'],
env: {
jest: true,
Expand Down
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Added `your feature` that allows ...
- [ ] I have tested this on a device/simulator for each compatible OS
- [ ] I updated the documentation with running `yarn generate` in the root folder
- [ ] I mentioned this change in `CHANGELOG.md`
- [ ] I updated the typings files (`index.d.ts`)
- [ ] I updated the typings files (`definitions.d.ts`)
- [ ] I added/ updated a sample (`/example`)

## Screenshot OR Video
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ package-lock.json
yarn.lock
/example/yarn.lock

# Compiled
lib
*.tgz

# Expo
.expo

Expand Down
25 changes: 11 additions & 14 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,30 +1,27 @@
# Contributing

## Setup for creating pull requests
## Creating pull requests

- Fork this project
- In your fork, create a branch, for example: `fix/camera-update`
- Add your changes
- Push and open a PR with your branch

## Testing my changes
The metro bundler under `/example` is set up to use the libraries files under root.
Which means, when you change something within `javascript/components/UserLocation.js`
it will be reflected in any scene in example that uses that component.
## Testing changes

The metro bundler under `/example` is set up to use the libraries files under root. Which means, when you change something within `javascript/components/UserLocation.js`, it will be reflected in any scene in `/example` that uses that component.

The library is a combination of Typescript and Javascript, which gets compiled into `/lib` for consumption by the `/example` project. This should work fine, but if you have any difficulty with the example trying to read the files in `/javascript` (outside of `/lib`), as a last resort you can run `npm pack` in the root, and then in `/example`, run `npm install ../rnmapbox-maps-<version>.tgz`.

## Best practices for PR's

- If you add a feature, make sure you add it to the documentation
- If you add an objective-c or java method, make sure you update the declaration file: `index.d.ts`.
- If you add an objective-c or java method, make sure you update the declaration file: `definitions.d.ts`.
- Make sure to use small concise commits
- Use meaningful commit messages
- Make sure to update/ add new tests for your changes
- If you add a new feature make sure to add a scene in `/example` for others to see/ test it

## Documentation
Documentation is generated from code blocks and comments.
It will be auto-generated when you commit changes.
If any changes are generated from your edits, the changed files will need to be added using `git add` before attempting the commit again.
To manually generate the changes, run `npm run generate`.

Notice, that changing the documentation in the individual <COMPONENT>.md within `/docs` will not suffice.
The correct way is the above described


Documentation is generated from code blocks and comments. It will be auto-generated when you commit changes. If any changes are generated from your edits, the changed files will need to be added using `git add` before attempting the commit again. To manually generate the changes, run `npm run generate`.
Loading