Loosen warping reqs for stress analysis #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbievanleeuwen
added
the
engineering
Owner
Author
|
@connorferster wondering if you've had a chance to look at this and whether or not it's fit for purpose for your use case? |
connorferster
approved these changes
Aug 29, 2022
Collaborator
|
Woo woo! We are up over 59.5% for code coverage! 60%, here we come! :) |
Owner
Author
|
😆 setting myself the goal of improving the test coverage over the coming weeks, we'll see how we go! Thinking about doing a bit of a refactor as well as switching the docs from RTD over to GH pages, similar to concreteproperties. Will break a few links in the github repo which I'll try to patch but I think it will be an overall improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only require a warping analysis to be performed for a stress analysis if the shear force or twisting moment is non-zero.