refactor: streamline update handling by removing download trigger

- Removed the triggerDownload function and its associated logic from the useAppUpdate hook.
- Updated the App and PanelFooter components to reflect the changes, simplifying the update process.
- The update now directly transitions to the downloading state without an intermediate available state.

Author: robinebers

src/App.tsx

@@ -55,7 +55,7 @@ function App() {
   const [maxPanelHeightPx, setMaxPanelHeightPx] = useState<number | null>(null)
   const maxPanelHeightPxRef = useRef<number | null>(null)
 
-  const { updateStatus, triggerDownload, triggerInstall } = useAppUpdate()
+  const { updateStatus, triggerInstall } = useAppUpdate()
 
   // Tick state to force re-evaluation of cooldown status
   const [cooldownTick, setCooldownTick] = useState(0)
@@ -565,7 +565,6 @@ function App() {
             onRefresh={handleRefresh}
             refreshDisabled={!canRefreshAll}
             updateStatus={updateStatus}
-            onUpdateDownload={triggerDownload}
             onUpdateInstall={triggerInstall}
           />
         </div>

src/components/panel-footer.tsx

@@ -7,49 +7,36 @@ interface PanelFooterProps {
   onRefresh: () => void;
   refreshDisabled?: boolean;
   updateStatus: UpdateStatus;
-  onUpdateDownload: () => void;
   onUpdateInstall: () => void;
 }
 
 function VersionDisplay({
   version,
   updateStatus,
-  onUpdateDownload,
   onUpdateInstall,
 }: {
   version: string;
   updateStatus: UpdateStatus;
-  onUpdateDownload: () => void;
   onUpdateInstall: () => void;
 }) {
   switch (updateStatus.status) {
-    case "available":
-      return (
-        <button
-          type="button"
-          onClick={onUpdateDownload}
-          className="text-xs text-primary hover:underline underline-offset-4 bg-transparent border-none p-0 cursor-pointer"
-        >
-          v{updateStatus.version} available
-        </button>
-      );
     case "downloading":
       return (
         <span className="text-xs text-muted-foreground">
           {updateStatus.progress >= 0
-            ? `Downloading... ${updateStatus.progress}%`
-            : "Downloading..."}
+            ? `Downloading update ${updateStatus.progress}%`
+            : "Downloading update..."}
         </span>
       );
     case "ready":
       return (
-        <button
-          type="button"
+        <Button
+          variant="destructive"
+          size="xs"
           onClick={onUpdateInstall}
-          className="text-xs text-primary hover:underline underline-offset-4 bg-transparent border-none p-0 cursor-pointer"
         >
           Restart to update
-        </button>
+        </Button>
       );
     case "installing":
       return (
@@ -75,15 +62,13 @@ export function PanelFooter({
   onRefresh,
   refreshDisabled,
   updateStatus,
-  onUpdateDownload,
   onUpdateInstall,
 }: PanelFooterProps) {
   return (
     <div className="flex justify-between items-center pt-1.5 border-t">
       <VersionDisplay
         version={version}
         updateStatus={updateStatus}
-        onUpdateDownload={onUpdateDownload}
         onUpdateInstall={onUpdateInstall}
       />
       {refreshDisabled ? (

src/hooks/use-app-update.ts

@@ -5,15 +5,13 @@ import { relaunch } from "@tauri-apps/plugin-process"
 
 export type UpdateStatus =
   | { status: "idle" }
-  | { status: "available"; version: string }
   | { status: "downloading"; progress: number } // 0-100, or -1 if indeterminate
   | { status: "installing" }
   | { status: "ready" }
   | { status: "error"; message: string }
 
 interface UseAppUpdateReturn {
   updateStatus: UpdateStatus
-  triggerDownload: () => void
   triggerInstall: () => void
 }
 
@@ -34,70 +32,62 @@ export function useAppUpdate(): UseAppUpdateReturn {
     let cancelled = false
     mountedRef.current = true
 
-    const checkForUpdate = async () => {
+    const checkAndDownload = async () => {
       if (!isTauri()) return
       try {
         const update = await check()
         if (cancelled) return
         if (update) {
           updateRef.current = update
-          setStatus({ status: "available", version: update.version })
+          // Immediately start downloading (no "available" state)
+          inFlightRef.current.downloading = true
+          setStatus({ status: "downloading", progress: -1 })
+
+          let totalBytes: number | null = null
+          let downloadedBytes = 0
+
+          try {
+            await update.download((event) => {
+              if (!mountedRef.current) return
+              if (event.event === "Started") {
+                totalBytes = event.data.contentLength ?? null
+                downloadedBytes = 0
+                setStatus({
+                  status: "downloading",
+                  progress: totalBytes ? 0 : -1,
+                })
+              } else if (event.event === "Progress") {
+                downloadedBytes += event.data.chunkLength
+                if (totalBytes && totalBytes > 0) {
+                  const pct = Math.min(100, Math.round((downloadedBytes / totalBytes) * 100))
+                  setStatus({ status: "downloading", progress: pct })
+                }
+              } else if (event.event === "Finished") {
+                setStatus({ status: "ready" })
+              }
+            })
+            setStatus({ status: "ready" })
+          } catch (err) {
+            console.error("Update download failed:", err)
+            setStatus({ status: "error", message: "Download failed" })
+          } finally {
+            inFlightRef.current.downloading = false
+          }
         }
       } catch (err) {
         if (cancelled) return
         console.error("Update check failed:", err)
       }
     }
 
-    void checkForUpdate()
+    void checkAndDownload()
 
     return () => {
       cancelled = true
       mountedRef.current = false
     }
   }, [setStatus])
 
-  const triggerDownload = useCallback(async () => {
-    const update = updateRef.current
-    if (!update) return
-    if (statusRef.current.status !== "available") return
-    if (inFlightRef.current.downloading || inFlightRef.current.installing) return
-
-    inFlightRef.current.downloading = true
-    setStatus({ status: "downloading", progress: -1 })
-
-    let totalBytes: number | null = null
-    let downloadedBytes = 0
-
-    try {
-      await update.download((event) => {
-        if (!mountedRef.current) return
-        if (event.event === "Started") {
-          totalBytes = event.data.contentLength ?? null
-          downloadedBytes = 0
-          setStatus({
-            status: "downloading",
-            progress: totalBytes ? 0 : -1,
-          })
-        } else if (event.event === "Progress") {
-          downloadedBytes += event.data.chunkLength
-          if (totalBytes && totalBytes > 0) {
-            const pct = Math.min(100, Math.round((downloadedBytes / totalBytes) * 100))
-            setStatus({ status: "downloading", progress: pct })
-          }
-        } else if (event.event === "Finished") {
-          setStatus({ status: "ready" })
-        }
-      })
-      setStatus({ status: "ready" })
-    } catch (err) {
-      console.error("Update download failed:", err)
-      setStatus({ status: "error", message: "Download failed" })
-    } finally {
-      inFlightRef.current.downloading = false
-    }
-  }, [setStatus])
-
   const triggerInstall = useCallback(async () => {
     const update = updateRef.current
     if (!update) return
@@ -118,5 +108,5 @@ export function useAppUpdate(): UseAppUpdateReturn {
     }
   }, [setStatus])
 
-  return { updateStatus, triggerDownload, triggerInstall }
+  return { updateStatus, triggerInstall }
 }