Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Travis to use docker to test on Xenial and Bionic #469

Merged
merged 11 commits into from
Aug 22, 2018
Merged

Migrate Travis to use docker to test on Xenial and Bionic #469

merged 11 commits into from
Aug 22, 2018

Conversation

traversaro
Copy link
Member

No description provided.

@traversaro
Copy link
Member Author

Fix #458

diegoferigo
diegoferigo approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!!

.ci/script.sh
@@ -0,0 +1,40 @@
#!/bin/sh
set -e

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using also set -u for variables not defined:

-u  Treat unset variables as an error when substituting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. What's the syntax ?

set -e -u

or

set -e
set -u

?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the same, probably even set -eu works

@traversaro traversaro mentioned this pull request Aug 21, 2018
Closed
@traversaro traversaro added this to the iDynTree 0.11 milestone Aug 21, 2018
@traversaro
Copy link
Member Author

Great, everything works fine and so in bionic we get the valgrind failures due to #456 . I guess we can disable bionic builds waiting for a better solution.

@traversaro traversaro changed the title Migrate Travis to use docker to test on Xenial and Bionic Migrate Travis to use docker to test on Xenial Aug 21, 2018
@traversaro traversaro changed the title Migrate Travis to use docker to test on Xenial Migrate Travis to use docker to test on Xenial and Bionic Aug 22, 2018
@traversaro
Copy link
Member Author

traversaro commented Aug 22, 2018 •
edited
Loading

I changed my mind. Let's keep the bionic build, let's just disable Valgrind on those, done in 14fb81f .

@traversaro traversaro merged commit 097e839 into robotology:devel Aug 22, 2018
@traversaro traversaro deleted the travis-docker branch August 22, 2018 09:30
This was referenced Aug 22, 2018
Closed
Merged
@diegoferigo diegoferigo mentioned this pull request Apr 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoferigo diegoferigo diegoferigo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
iDynTree 0.11
Development

Successfully merging this pull request may close these issues.
2 participants
@traversaro @diegoferigo