Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename libYARP_telemetry in librobometry #173

Merged
merged 3 commits into from
May 6, 2022
Merged

Rename libYARP_telemetry in librobometry #173

merged 3 commits into from
May 6, 2022

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented May 6, 2022

Also, the cmake target has been changed accordingly.

Related discussion #172

On the user side these are the changes to be made for using robometry:

CMake

-     find_package(YARP COMPONENTS telemetry)
+     find_package(robometry)
-     find_package(YARP_telemetry)
+     find_package(robometry)
-     target_link_libraries(foo PUBLIC YARP::YARP_telemetry)
+     target_link_libraries(foo PUBLIC robometry::robometry)

C++

-     using namespace yarp::telemetry::experimental;
+     using namespace robometry;
-     #include <yarp/telemetry/experimental/BufferManager.h>
+     #include <robometry/BufferManager.h>

This new name will be part of the first major release (v1.0.0)

Please review the code. I may have forgot something, I tested it also importing from and external code (wearables repo)

cc @GiulioRomualdi

Also the cmake target have been changed accordingly
@Nicogene Nicogene added the enhancement New feature or request label May 6, 2022
CMakeLists.txt Outdated Show resolved Hide resolved
src/librobometry/CMakeLists.txt Outdated Show resolved Hide resolved
src/librobometry/include/robometry/api.h Outdated Show resolved Hide resolved
@Nicogene Nicogene requested a review from S-Dafarra May 6, 2022 12:49
@Nicogene Nicogene merged commit f1ea8d9 into master May 6, 2022
@Nicogene Nicogene deleted the feat/robometry branch May 6, 2022 13:26
Nicogene added a commit to robotology/wearables that referenced this pull request May 10, 2022
Nicogene added a commit to robotology/wearables that referenced this pull request May 10, 2022
Nicogene added a commit to robotology/wearables that referenced this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants