Add SelectCommand implementation #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
reviewed
Dec 19, 2022
| SelectCommandKey &operator=(const py::handle src) { | ||
| py::gil_scoped_acquire gil; | ||
| m_v = py::reinterpret_borrow<py::object>(src); | ||
| m_hash = m_v.attr("__hash__")().cast<std::size_t>(); |
Member
There was a problem hiding this comment.
isn't this technically incorrect if a __hash__ attribute is set on an object? hash() would still call the real __hash__ method, but accessing the attribute would not
I believe pybind11 has a helper for this: https://pybind11.readthedocs.io/en/stable/reference.html#_CPPv44hash6handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @mrguisamuel