Skip to content

refactor: enhance validation for telephone numbers and URLs #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 1 commit into from
Nov 7, 2025
Merged

refactor: enhance validation for telephone numbers and URLs #1422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions backend/src/entities/shared-jobs/shared-jobs.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,11 @@ export class SharedJobsService {
}

private isValueTelephoneNumber(value: unknown): boolean {
return ValidationHelper.isValidPhoneNumber(String(value));
if (typeof value !== 'string') {
return false;
}
const phoneRegex = /^\+\d{10,}$/;
return phoneRegex.test(value) && ValidationHelper.isValidPhoneNumber(value);
}

private isValueRgbColor(value: unknown): boolean {
Expand Down Expand Up @@ -271,7 +275,8 @@ export class SharedJobsService {
if (typeof value !== 'string') {
return false;
}
return ValidationHelper.isValidUrl(value);
const urlRegex = /^https?:\/\/.+/;
return urlRegex.test(value) && ValidationHelper.isValidUrl(value);
}

private isValueJSON(value: unknown): boolean {
Expand Down