Add typing to Stacky #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary As indicated in the title, the idea is to have things more strongly typed so that we can run mypy on diff to ensure that we have less risk of regressing. Testing Ran: ``` mypy src ```
yashNaN
approved these changes
Feb 8, 2024
Contributor
yashNaN
left a comment
yashNaN
left a comment
There was a problem hiding this comment.
This is amazing! Thanks for adding all the typing. If you've used this and things worked as expected good to merge.
Contributor
|
@pmenglund @tudor Can y'all please accept, i don't have authority to approve this anymore :( |
Contributor
Author
|
@yashNaN it's easy to fix so that you can approve this diff ;-) |
pmenglund
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As indicated in the title, the idea is to have things more strongly
typed so that we can run mypy on diff to ensure that we have less risk
of regressing.
Testing
Ran: