-
Notifications
You must be signed in to change notification settings - Fork 365
add new file #1550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new file #1550
Conversation
|
@jimcat8 there is nothing to say about this chapter. It will be a very great one. It will complete the grep part of the admin book with a lot more complex things. Congrats jimcat8, I know it is not easy to write that sort of chapter from scratch! |
|
I've just added my approval. This is an excellent chapter, rich in information. The only comment I have concerns the title (that's saying something). It's a cool title for a blog, but I think it clashes with the titles of the other chapters in the guide. Maybe a better title: "Deep dive into grep, sed and awk - the three Swordsmen". @sspencerwire could we merge this PR if @jimcat8 is ready (it's actually in draft mode) and has change the title? |
I'm ready to merge the PR as soon as @jimcat8 takes it out of draft mode. It may require some light editing after merging, but it doesn't look like it will take much. |
Test results for e5c4e93:
|
sspencerwire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimcat8 It looks good. There may be some light editing needed, but I'm inclined to merge this and let Anna take a look if she has time today, or I'll run through it tomorrow.
Author checklist (Completed by original Author)
Rocky Documentation checklist (Completed by Rocky team)