Skip to content

Conversation

@jimcat8
Copy link
Contributor

@jimcat8 jimcat8 commented Oct 17, 2023

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@alemorvan
Copy link
Contributor

@jimcat8 there is nothing to say about this chapter. It will be a very great one. It will complete the grep part of the admin book with a lot more complex things.

Congrats jimcat8, I know it is not easy to write that sort of chapter from scratch!
It's a very good idea!

alemorvan
alemorvan previously approved these changes Dec 28, 2023
@alemorvan
Copy link
Contributor

I've just added my approval. This is an excellent chapter, rich in information.
It belongs in the administrator's guide (or one day even in an advanced administrator's guide).
Well done Jimcat.

The only comment I have concerns the title (that's saying something). It's a cool title for a blog, but I think it clashes with the titles of the other chapters in the guide.

Maybe a better title: "Deep dive into grep, sed and awk - the three Swordsmen".

@sspencerwire could we merge this PR if @jimcat8 is ready (it's actually in draft mode) and has change the title?

@sspencerwire
Copy link
Contributor

I've just added my approval. This is an excellent chapter, rich in information. It belongs in the administrator's guide (or one day even in an advanced administrator's guide). Well done Jimcat.

The only comment I have concerns the title (that's saying something). It's a cool title for a blog, but I think it clashes with the titles of the other chapters in the guide.

Maybe a better title: "Deep dive into grep, sed and awk - the three Swordsmen".

@sspencerwire could we merge this PR if @jimcat8 is ready (it's actually in draft mode) and has change the title?

I'm ready to merge the PR as soon as @jimcat8 takes it out of draft mode. It may require some light editing after merging, but it doesn't look like it will take much.

@jimcat8 jimcat8 marked this pull request as ready for review January 7, 2024 01:54
@github-actions
Copy link

github-actions bot commented Jan 7, 2024

Test results for e5c4e93:

Number of broken URLs: 9

URL,RESULT,FILENAME
 https://dl.rockylinux.org/pub/rocky/9.2/live/x86_64/,failed,guides/desktop/xfce_installation.md
 https://dl.rockylinux.org/pub/rocky/9.2/live/x86_64/,failed,guides/desktop/mate_installation.md
 https://dl.rockylinux.org/pub/rocky/9.2/live/x86_64/,failed,guides/desktop/kde_installation.md
 https://bandism.net/,failed,guides/contribute/README.md
 https://www.linode.com/docs/guides/beginners-guide-to-lxd-reverse-proxy,failed,guides/containers/lxd_web_servers.md
 https://google.com/books/index.html\ntitle//tcp,failed,books/admin_guide/15-three-swordsmen.md
 https://google.com/books/index.html,failed,books/admin_guide/15-three-swordsmen.md
 https:%%google.com/books/index.html,failed,books/admin_guide/15-three-swordsmen.md
 https://mirror2.sandyriver.net/pub/rocky/8.8/PowerTools/x86_64/os/,failed,books/admin_guide/13-softwares.md

Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimcat8 It looks good. There may be some light editing needed, but I'm inclined to merge this and let Anna take a look if she has time today, or I'll run through it tomorrow.

@sspencerwire sspencerwire merged commit 872253e into rocky-linux:main Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants