Skip to content

Conversation

@j0eybrinkman
Copy link
Contributor

@j0eybrinkman j0eybrinkman commented Jan 26, 2024

Updated and tested for Rocky 9.3

Added $ to bash commands missing it for consistency.

Author checklist (Completed by original Author)

  • [x ] Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • [ x] If applicable, steps and instructions have been tested to work
  • [ x] Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

Updated and tested for Rocky 9.3

Added $ to bash commands missing it for consistency.
@alemorvan
Copy link
Contributor

Good job @j0eybrinkman
About the missing $:
The markdown linter ask us :

  • no $ when thé command print nothing
  • add a $ when the command return a value

So please you can remove the $ you added

Thank you for this necessary update

@sspencerwire
Copy link
Contributor

Good job @j0eybrinkman About the missing $: The markdown linter ask us :

  • no $ when thé command print nothing
  • add a $ when the command return a value

So please you can remove the $ you added

Thank you for this necessary update

@j0eybrinkman I was just going to echo what @alemorvan put in here too. Here's the deal: If you are a user who is going through the procedure to do the install on your machine, then you probably would be using the copy and paste method for these commands. If you have the $ there, what happens is that is copied also unless you also exclude the prompt. (see https://docs.rockylinux.org/guides/contribute/rockydocs_formatting/#suppressing-the-displayed-prompt-and-automatic-line-feed)

Unfortunately, for your PR there is more. Rather than removing the 8.x content (as you've done) you should probably add sections for installing with 9.x. This can be done using this routine always making the latest version (9.x) the first tab.

Can you perhaps take another stab at this? I appreciate your efforts and contributions!

Returned instructions for rocky 8.9 .

revised formatting:
- used $ only for commands with output
- added { .sh data-copy="" } to commands that use $ and have output
- added ````markdown```` to sequential bash commands so each can be copied, codeblock inside a codeblock.

Fixed typo I missed in path for curl command.
@j0eybrinkman
Copy link
Contributor Author

Hello thank you for the advice. After reading the formatting guide I made some new changes as well as returned the Rocky 8.9 instructions - using the markdown you provided.

Remove markdown tics. Combine the enable and start with the --now flag.
@sspencerwire
Copy link
Contributor

ALMOST there. :-) The "````markdown" tag (and the 4 ending back tics) is not needed and will not yield the correct results. I've removed those. The other change I made, is to combine the enable and start together. For example:

systemctl enable --now httpd

That is just to make the document a little more concise. I'll merge this now and take a look at it to make sure it renders OK. Thank you @j0eybrinkman !

@sspencerwire sspencerwire merged commit a0225ec into rocky-linux:main Jan 26, 2024
@github-actions
Copy link

Test results for 29ff1ff:

Number of broken URLs: 2

URL,RESULT,FILENAME
 https://www.linode.com/docs/guides/beginners-guide-to-lxd-reverse-proxy,failed,guides/containers/lxd_web_servers.md
 https://coding.tools/regex-tester,failed,books/admin_guide/15-three-swordsmen.md

@j0eybrinkman
Copy link
Contributor Author

@sspencerwire Thank you for the help, I will spend some more time reading the formatting docs and to try and avoid these mistakes in the future!! @alemorvan Thanks for creating this article I have really enjoyed it.

@alemorvan
Copy link
Contributor

@j0eybrinkman look at the php-fpm page
My prefered, more technical

Please note we have as project to make a lemp/lamp book

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants