-
Notifications
You must be signed in to change notification settings - Fork 366
Update php.md #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update php.md #1693
Conversation
Updated and tested for Rocky 9.3 Added $ to bash commands missing it for consistency.
|
Good job @j0eybrinkman
So please you can remove the $ you added Thank you for this necessary update |
@j0eybrinkman I was just going to echo what @alemorvan put in here too. Here's the deal: If you are a user who is going through the procedure to do the install on your machine, then you probably would be using the copy and paste method for these commands. If you have the $ there, what happens is that is copied also unless you also exclude the prompt. (see https://docs.rockylinux.org/guides/contribute/rockydocs_formatting/#suppressing-the-displayed-prompt-and-automatic-line-feed) Unfortunately, for your PR there is more. Rather than removing the 8.x content (as you've done) you should probably add sections for installing with 9.x. This can be done using this routine always making the latest version (9.x) the first tab. Can you perhaps take another stab at this? I appreciate your efforts and contributions! |
Returned instructions for rocky 8.9 .
revised formatting:
- used $ only for commands with output
- added { .sh data-copy="" } to commands that use $ and have output
- added ````markdown```` to sequential bash commands so each can be copied, codeblock inside a codeblock.
Fixed typo I missed in path for curl command.
|
Hello thank you for the advice. After reading the formatting guide I made some new changes as well as returned the Rocky 8.9 instructions - using the markdown you provided. |
Remove markdown tics. Combine the enable and start with the --now flag.
|
ALMOST there. :-) The "````markdown" tag (and the 4 ending back tics) is not needed and will not yield the correct results. I've removed those. The other change I made, is to combine the enable and start together. For example: That is just to make the document a little more concise. I'll merge this now and take a look at it to make sure it renders OK. Thank you @j0eybrinkman ! |
Test results for 29ff1ff:
|
|
@sspencerwire Thank you for the help, I will spend some more time reading the formatting docs and to try and avoid these mistakes in the future!! @alemorvan Thanks for creating this article I have really enjoyed it. |
|
@j0eybrinkman look at the php-fpm page Please note we have as project to make a lemp/lamp book |
Updated and tested for Rocky 9.3
Added $ to bash commands missing it for consistency.
Author checklist (Completed by original Author)
Rocky Documentation checklist (Completed by Rocky team)