Skip to content

Conversation

@j0eybrinkman
Copy link
Contributor

@j0eybrinkman j0eybrinkman commented Feb 15, 2024

fixed typos - deacticate -> deactivate - 1127.0.0.1 -> 127.0.0.1

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j0eybrinkman It looks like somehow you deleted the whole file and then re-added it. :-) Can you verify that this is what you wanted? Probably a better way would have been to just edit the section you wanted to fix. Do you want to try again? I can close this PR... OR... I can merge it and then verify everything is OK afterward.

@j0eybrinkman
Copy link
Contributor Author

@sspencerwire I'm not sure why but when I click the pencil icon then edit and make a commit it replaces the entire file. I'm not deleting the entire file so I am not sure why it is doing this.

@j0eybrinkman
Copy link
Contributor Author

@sspencerwire Maybe this is why it is replacing the entire file?
image

@sspencerwire
Copy link
Contributor

@sspencerwire Maybe this is why it is replacing the entire file? image

I'm not sure why it's doing that. I know what you were trying to do, so if you like, I can just do it this time.

@sspencerwire
Copy link
Contributor

I'm not sure why it's doing that. I know what you were trying to do, so if you like, I can just do it this time.

What I should have done is tried to edit the file your way. I'm going to close my PR and try that.

@sspencerwire
Copy link
Contributor

Reopening this one, as I had the same experience as you using the pencil edit method and I want to make sure it edits things OK.

@sspencerwire sspencerwire reopened this Feb 15, 2024
@sspencerwire sspencerwire merged commit d9f12de into rocky-linux:main Feb 15, 2024
@github-actions
Copy link

Test results for 35d562a:

Number of broken URLs: 6

URL,RESULT,FILENAME
 https://azure.microsoft.com/en-us/,failed,guides/automation/templates-automation-packer-vsphere.md
 https://www.linode.com/docs/guides/beginners-guide-to-lxd-reverse-proxy,failed,guides/containers/lxd_web_servers.md
 https://linoxide.com/install-cockpit-on-almalinux-or-rocky-linux/,failed,guides/security/firewalld-beginners.md
 http://ip_address:9090,failed,guides/virtualization/cockpit-machines.md
 https://oktools.net/regex,failed,books/sed_awk_grep/1_regular_expressions_vs_wildcards.md
 https://csrc.nist.gov/projects/security-content-automation-protocol,failed,books/disa_stig/disa_stig_part2.md

@sspencerwire
Copy link
Contributor

@j0eybrinkman The file looks fine after merging. I've never seen that message before (until today), but merging didn't foul up the file at all. Thank you for your contribution!

@j0eybrinkman
Copy link
Contributor Author

@sspencerwire Ofc, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants