Skip to content

Conversation

@SergeCroise
Copy link
Contributor

@SergeCroise SergeCroise commented Feb 26, 2024

  • if the tag contributors exists, the list should not be empty

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

- if the tag contributors exists, it should not be empty
@SergeCroise
Copy link
Contributor Author

SergeCroise commented Feb 26, 2024

Hello @gannazhyrnova , hello @sspencerwire ,
Please review,
feel free to modify my changes or revert.

@github-actions
Copy link

Test results for 9e6d02f:

Number of broken URLs: 3

URL,RESULT,FILENAME
 https://www.linode.com/docs/guides/beginners-guide-to-lxd-reverse-proxy,failed,guides/containers/lxd_web_servers.md
 https://linoxide.com/install-cockpit-on-almalinux-or-rocky-linux/,failed,guides/security/firewalld-beginners.md
 https://oktools.net/regex,failed,books/sed_awk_grep/1_regular_expressions_vs_wildcards.md

@SergeCroise SergeCroise marked this pull request as draft February 26, 2024 13:45
@sspencerwire
Copy link
Contributor

Hi @SergeCroise Neither @gannazhyrnova nor myself have edited this document yet. So adding either of us as a contributor at this point is not necessary. Thank you though!

@sspencerwire
Copy link
Contributor

@SergeCroise Now I understand this PR. :-) I hadn't finished reviewing the PRs in the repository. You entered this as a draft, I'll see if I can undo that. Thank you again!

@sspencerwire sspencerwire marked this pull request as ready for review February 26, 2024 14:15
@sspencerwire sspencerwire merged commit 5c44ae7 into rocky-linux:main Feb 26, 2024
@SergeCroise SergeCroise deleted the patch-53 branch February 26, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants