-
Notifications
You must be signed in to change notification settings - Fork 365
added 9.3 installation instructions #1853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ```bash | ||
| sudo dnf install httpd | ||
| ``` | ||
| ```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have many examples of unnecessary whitespace throughout this PR. This shouldn't be here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have many examples of unnecessary whitespace throughout this PR. This shouldn't be here.
Actually, @neelchauhan, he is trying to implement this: https://docs.rockylinux.org/guides/contribute/rockydocs_formatting/#tabbed-content-within-a-document
Which does require the four spaces he is showing. There's an issue with the tabs though, that I've outlined in another comment.
sspencerwire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j0eybrinkman This is good work! There's a slight problem though. I'd recommend editing this and keeping ALL of the 8.9 and 9.3 instructions together, rather than separating them throughout the document. If you want to do it the way you've got it written now, then the alternative change would be to change the tabs to describe the section, for example:
=== "8.9 PHP module list"
and
=== "9.3 PHP module list"
But overall I think it is far better to only have the two tabs in the document (8.9 and 9.3) and have ALL of the instructions for each version contained inside
You can leave generic instructions (those that work for either version) out of the tabbed content.
Have you looked to see how this appears in the web interface? (In other words, have you successfully installed a local documentation implementation and seen what happens to this document as it is formatted? If not, then I would definitely suggest bundling all of the instructions for each version under one tab.
Yes I used the venv method to render the web page before submitting PR. |
|
Hi @sspencerwire I updated the tabs to be more descriptive. I do prefer the individual tabs for each section of the document rather than grouping them all together. Each set of commands is available under its respective section in the table of contents that way which I like. |
Test results for 6d45d17:
|
Ok. Thanks @j0eybrinkman I'll approve the changes and merge them and take a look in the web env. :-) |
Author checklist (Completed by original Author)
Rocky Documentation checklist (Completed by Rocky team)