Skip to content

Conversation

@EzequielBruni
Copy link
Collaborator

@EzequielBruni EzequielBruni commented Mar 4, 2024

I edited the installation section to remove the whole thing about nginx-mainline. It's really not needed anymore.

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

I edited the installation section to remove the whole thing about nginx-mainline. It's really not needed anymore.
@github-actions
Copy link

github-actions bot commented Mar 4, 2024

Test results for 986ea66:

Number of broken URLs: 3

URL,RESULT,FILENAME
 https://azure.microsoft.com/en-us/,failed,guides/automation/templates-automation-packer-vsphere.md
 https://www.linode.com/docs/guides/beginners-guide-to-lxd-reverse-proxy,failed,guides/containers/lxd_web_servers.md
 https://docs.rockylinux.org/gemstones/docker/,failed,guides/containers/rancher_and_kubernetes.md

Copy link
Contributor

@SergeCroise SergeCroise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new admonitions with type "and title"
would make the work for translators easier
(feel free to modify or revert my changes).


From there, you could just start dropping HTML files into the `/usr/share/nginx/html/` directory to build a simple, static website. The configuration file for the default website/virtual host is called “nginx.conf” and it’s in `/etc/nginx/`. It also holds a number of other basic Nginx server configurations, so even if you choose to move the actual website config to another file, you should probably leave the rest of "nginx.conf" intact.

!!! Note
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
!!! Note
!!! note "Note"


## Configuring the Firewall

!!! Note
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
!!! Note
!!! note "Note"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeCroise As noted in another PR, I'm not going to convert the regular admonition to a custom admonition. The translators said it was not necessary when we brought this up before.

Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this @EzequielBruni !!

@sspencerwire sspencerwire merged commit 4d0ddf0 into main Mar 4, 2024
@sspencerwire sspencerwire deleted the EzequielBruni-patch-1 branch April 19, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants