Skip to content

Conversation

@neelchauhan
Copy link
Contributor

@neelchauhan neelchauhan commented Mar 17, 2024

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@neelchauhan
Copy link
Contributor Author

As a note, I'm not sure if automation is the correct place to put this, but I didn't see another better section to put this, so hence I used automation.

sspencerwire
sspencerwire previously approved these changes Mar 18, 2024
Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neelchauhan Thank you! This seems very brand-specific, BUT useful none-the-less.

@sspencerwire
Copy link
Contributor

As a note, I'm not sure if automation is the correct place to put this, but I didn't see another better section to put this, so hence I used automation.

Message me on Mattermost: Perhaps we could create a new section. What would you suggest? I'm traveling, so even though I've approved this PR for merging, I'll wait a bit for your ideas.

Copy link
Contributor

@SergeCroise SergeCroise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Punctuation according to this example:
https://www.merriam-webster.com/dictionary/e.g.#examples

@neelchauhan
Copy link
Contributor Author

Message me on Mattermost: Perhaps we could create a new section. What would you suggest? I'm traveling, so even though I've approved this PR for merging, I'll wait a bit for your ideas.

I'd like a hardware section for hardware-specific guides. Not just HPE, but also Dell, Raspberry Pi, Apple, et al.

I took a while to respond because I'm moving back to NYC and was busy packing.

@github-actions
Copy link

Test results for 71b93bf:

Number of broken URLs: 1

URL,RESULT,FILENAME
 https://www.linode.com/docs/guides/beginners-guide-to-lxd-reverse-proxy,failed,guides/containers/lxd_web_servers.md

@sspencerwire sspencerwire merged commit a9d1cb2 into rocky-linux:main Mar 20, 2024
@neelchauhan neelchauhan deleted the hpe_amsd branch November 29, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants