Skip to content

Conversation

@nishaaaaaant
Copy link
Contributor

@nishaaaaaant nishaaaaaant commented Mar 31, 2024

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@github-actions
Copy link

Test results for 13773ac:

Number of broken URLs: 3

URL,RESULT,FILENAME
 https://www.linode.com/docs/guides/beginners-guide-to-lxd-reverse-proxy,failed,guides/containers/lxd_web_servers.md
 https://www.ssllabs.com/ssltest/,failed,guides/web/caddy.md
 https://hbjy.dev/,failed,guides/contribute/README.md

6. This will allow you to drag and drop files here or browse to them on your computer. Go ahead and use the method that you prefer.
7. Once the file is uploaded, the next thing you need to do is create a Pull Request. This request lets the upstream administrators know you have a new file (or files) that you want them to merge with the master branch.
8. Click on "Pull Request" in the upper-left corner of the screen.
8. Click on `Pull Request` in the upper-left corner of the screen.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically @nishaaaaaant , "Pull Request" is not a code block. Is there a better way to format it w/o using the backticks or quotes? Otherwise, I don't see anything not worthy of merging. Take a look and perhaps fix that, or provide some justification for it if you feel strongly about it. Thank you!

Copy link
Contributor Author

@nishaaaaaant nishaaaaaant Mar 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sspencerwire
I can change it to
Click on the ++"Pull Request"++ button in the upper-left corner of the screen.
Since it is a button.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note worthy merging for the whole PR or just the createnew.md file?

@sspencerwire
Copy link
Contributor

Thanks @nishaaaaaant. I'm merging now. ;-)

@sspencerwire sspencerwire merged commit 4120bd5 into rocky-linux:main Mar 31, 2024
@nishaaaaaant nishaaaaaant deleted the fix-mardown-violation branch April 1, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants