Skip to content

Conversation

@hs303
Copy link
Contributor

@hs303 hs303 commented Jul 9, 2024

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

wsoyinka
wsoyinka previously approved these changes Jul 9, 2024
Copy link
Member

@wsoyinka wsoyinka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hs303 - My quick read through this guide was very enjoyable.

Thank you for contributing this :-) !

(p.s. I might recommend a slightly different title for the guide just so that it does not give the wrong impression that it's about hardening of the "systemd" sub-system itself.)

@hs303
Copy link
Contributor Author

hs303 commented Jul 9, 2024

@wsoyinka thanks for the kind feedback. Indeed the title might be confusing. I've changed it to 'Systemd Units Hardening'.

@github-actions
Copy link

github-actions bot commented Jul 9, 2024

Test results for c5f844b:

Number of broken URLs: 1

URL,RESULT,FILENAME
 https://azuremarketplace.microsoft.com/en-us/marketplace/apps/resf.rockylinux-aarch64,failed,guides/cloud/migration-to-new-azure-images.md

Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @hs303! This looks great! I'll run it through the editor.

@sspencerwire
Copy link
Contributor

@wsoyinka thanks for the kind feedback. Indeed the title might be confusing. I've changed it to 'Systemd Units Hardening'.

@hs303 did you mean to end up with two submissions in this PR? There are two files one with the name you show here, and one with (what I think was) the original name. My guess is that you want to remove that one? I can do that before it is merged, just let me know, or you can remove it yourself too.

@hs303
Copy link
Contributor Author

hs303 commented Jul 9, 2024

Somehow I've messed it up by renaming the file. Could you please fix this @sspencerwire? Thanks!

@sspencerwire
Copy link
Contributor

Somehow I've messed it up by renaming the file. Could you please fix this @sspencerwire? Thanks!
I'll take care of it. Thank you again!

@sspencerwire sspencerwire changed the base branch from main to edit_systemd_hardening July 9, 2024 20:26
@sspencerwire sspencerwire merged commit bacc016 into rocky-linux:edit_systemd_hardening Jul 9, 2024
sspencerwire added a commit that referenced this pull request Jul 9, 2024
* systemd hardening (#2173)

* ssh_ca_key_signing

* minor corrections

* minor changes to improve readability; key revocation added

* systemd hardening

* minor corrections

* title change

* Editing `systemd_hardening.md`
* remove the old `systemd_hardening.md` and move `systemd_unit_hardening.md` to `systemd_hardening.md`
* remove passive voice phrasing as much as possible (there were some still remaining)
* use `systemd` consistently
* some sentence simplification
* replace conjunctions with full words
* code blocks must have a fenced attribute (bash, text, etc.)
* fix a couple of spelling issues

---------

Co-authored-by: hs303 <84558934+hs303@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants