Skip to content

Conversation

@cyrilbois
Copy link
Contributor

@cyrilbois cyrilbois commented Aug 21, 2024

Fix broken link in docs/guides/communications/asterisk_installation.it.md and asterisk_installation.ko.md
Add Cyrilex (my website), an online visual regex tester, to "Introducing regular expressions" in docs/books/sed_awk_grep/1_regular_expressions_vs_wildcards.md and 1_regular_expressions_vs_wildcards.uk.md

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@sspencerwire
Copy link
Contributor

@cyrilbois Thanks for your efforts here! Unfortunately, making changes to language files, other than English, is not allowed within this process. We have a Crowdin interface where translators take the English source document and then translate it into their language of choice. Making changes outside of this environment causes problems there.
This file: "docs/books/sed_awk_grep/1_regular_expressions_vs_wildcards.md" is OK to change. If you would like to remove the 3 other files, I'll merge your change to that file. Thank you again! If you have questions, please don't hesitate to ask.

@github-actions
Copy link

Test results for 4f1057f:

Number of broken URLs: 2

URL,RESULT,FILENAME
 http://www.neelc.org/,failed,guides/contribute/README.md
 https://certbot.eff.org/instructions?ws=apache&os=centosrhel8,failed,guides/security/generating_ssl_keys_lets_encrypt.md

@cyrilbois
Copy link
Contributor Author

@sspencerwire Thank you for the explanations! I removed the language files.

@sspencerwire
Copy link
Contributor

@all-contributors add @cyrilbois for content

@allcontributors
Copy link
Contributor

@sspencerwire

I've put up a pull request to add @cyrilbois! 🎉

@sspencerwire sspencerwire merged commit 1d934c0 into rocky-linux:main Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants