This repository was archived by the owner on Nov 5, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 36
feat: support smooth and auto scrollBehavior prop
#220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for vue-virtual-scroll-grid accepted.
|
Contributor
|
💯💯💯💯💯 |
rocwang
suggested changes
May 31, 2022
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Code looks good to me, but would you mind updating the documentation in README.md, under the "Available Props" section?
Contributor
Author
|
Sure! |
mesqueeb
reviewed
May 31, 2022
Co-authored-by: Luca Ban <mesqueeb@users.noreply.github.com>
Contributor
|
@rocwang let me know if you released this one 🙏🏻 |
rocwang
approved these changes
Jun 1, 2022
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide options
smooth,autofor scrollBehaviorIn my use case, I'll open a page with dynamic route id, so the url will be like
localhost:3000/users/:userId.The page has a
Gridcomponent that is for displaying all users on the left side, and displaying current user information on the right side depending on the:userId.So I hope when user refreshing/entering the page,
Gridcan immediately scroll to the index at the first time instead of smoothly scroll to the index.That's the reason I need a way to decide when the scrollBehavior is
smoothorautoPlease checkout the implementation when you're available, and feel free to let me know if you have better solution thanks.