This repository was archived by the owner on Nov 5, 2023. It is now read-only.
feat: support horizontal scrolling (#141) #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for vue-virtual-scroll-grid accepted.
|
rocwang
reviewed
Jun 1, 2022
.gitignore
Outdated
| dist | ||
| dist-ssr | ||
| *.local | ||
| .env |
Owner
There was a problem hiding this comment.
I think we should keep .env out of .gitignore. For local env, we should use .env.local as Vue/Vite's convention.
rocwang
suggested changes
Jun 1, 2022
Owner
There was a problem hiding this comment.
This looks awesome! Thanks for your contribution!
Two minor things:
- Would you mind updating the documentation in
README.mdto cover this new feature? - We just merged #220 , which lead to some conflicts with your PR here. Could you rebase your PR to resolve these conflicts?
rocwang
reviewed
Jun 1, 2022
src/demo/Control.vue
Outdated
| <p :class="$style.category">Scroll mode:</p> | ||
|
|
||
| <div :class="$style.radioList"> | ||
| <label for="all" :class="$style.radioLabel"> |
Owner
There was a problem hiding this comment.
Suggested change
| <label for="all" :class="$style.radioLabel"> | |
| <label for="vertical" :class="$style.radioLabel"> |
rocwang
reviewed
Jun 1, 2022
src/demo/Control.vue
Outdated
| Vertical | ||
| </label> | ||
|
|
||
| <label for="mens" :class="$style.radioLabel"> |
Owner
There was a problem hiding this comment.
Suggested change
| <label for="mens" :class="$style.radioLabel"> | |
| <label for="horizontal" :class="$style.radioLabel"> |
Contributor
Author
|
@rocwang I can rebase, but i have no idea what i should write in |
Contributor
Author
|
Mb something like that. I also did some fixes of #220 during rebase i hope it's ok. |
rocwang
approved these changes
Jun 1, 2022
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support of horizontal scrolling. This feature uses
grid-auto-flowcss property to infer scroll mode. Demo updated.