Add readavailable(::FileBuffer)
#160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a method for `FileBuffer`s to `readavailable` that precisely matches the behavior for `IOBuffer`s. This definition permits downstream niceties such as `CSV.read(::S3Path, ...)`.
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 91.91% 91.91%
=======================================
Files 12 12
Lines 1224 1225 +1
=======================================
+ Hits 1125 1126 +1
Misses 99 99
Continue to review full report at Codecov.
|
Owner
|
LGTM, thanks! |
Owner
|
Tag should be released shortly. |
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a method for
FileBuffers toreadavailablethat precisely matches the behavior forIOBuffers. This definition permits downstream niceties such asCSV.read(::S3Path, ...).I've also bumped the patch version as a separate commit.