Skip to content

Conversation

@rofinn
Copy link
Owner

@rofinn rofinn commented Jul 19, 2019

Use properties rather than accessors and add a factory method for Path(path, segments).

Repository owner deleted a comment from codecov-io Jul 20, 2019
@codecov-io
Copy link

codecov-io commented Jul 20, 2019

Codecov Report

Merging #32 into master will increase coverage by 0.45%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   84.47%   84.92%   +0.45%     
==========================================
  Files          11       11              
  Lines         728      710      -18     
==========================================
- Hits          615      603      -12     
+ Misses        113      107       -6
Impacted Files Coverage Δ
src/FilePathsBase.jl 100% <ø> (ø) ⬆️
src/posix.jl 66.66% <100%> (+2.66%) ⬆️
src/system.jl 71.79% <100%> (-0.24%) ⬇️
src/libc.jl 55.55% <100%> (+3.55%) ⬆️
src/windows.jl 82.35% <100%> (+7.88%) ⬆️
src/status.jl 100% <100%> (ø) ⬆️
src/path.jl 80.26% <80.64%> (-0.86%) ⬇️
src/test.jl 97.48% <91.66%> (-0.1%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f16998a...3811987. Read the comment docs.

@rofinn rofinn merged commit a0076f2 into master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants