Fix sync to always respect walkpath order. #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, we could run into issues where a parent doesn't exist yet when copying files.
```
julia> index = Dict(Tuple(setdiff(p.segments, src.segments)) => p for p in walkpath(src))
Dict{Tuple{String,Vararg{String,N} where N},PosixPath} with 5 entries:
("folder1", "folder2") => /var/folders/h_/vkjv56410m7f75g9ffp46mf80000gp/T/tmpcJbzPa/folder1/folder2
("folder1",) => /var/folders/h_/vkjv56410m7f75g9ffp46mf80000gp/T/tmpcJbzPa/folder1
("folder1", "file2") => /var/folders/h_/vkjv56410m7f75g9ffp46mf80000gp/T/tmpcJbzPa/folder1/file2
("folder1", "folder2", "file3") => /var/folders/h_/vkjv56410m7f75g9ffp46mf80000gp/T/tmpcJbzPa/folder1/folder2/file3
("file1",) => /var/folders/h_/vkjv56410m7f75g9ffp46mf80000gp/T/tmpcJbzPa/file1
```
This would try and copy folder1/folder2 before creating folder1 because of how the segments were hashed.
An OrderedDict would also resolve this, but we don't want to depend on external dependencies in FilePathsBase.
- Check size and time - Provide optional function that specify whether to sync (e.g., checksums)
Repository owner
deleted a comment from
codecov-io
Aug 23, 2019
Repository owner
deleted a comment from
codecov-io
Aug 23, 2019
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 84.27% 84.15% -0.12%
==========================================
Files 11 11
Lines 763 789 +26
==========================================
+ Hits 643 664 +21
- Misses 120 125 +5
Continue to review full report at Codecov.
|
nicoleepp
approved these changes
Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, we could run into issues where a parent doesn't exist yet when copying files.
This would try and copy folder1/folder2 before creating folder1 because of how the segments were hashed.
An OrderedDict would also resolve this, but we don't want to depend on external dependencies in FilePathsBase.