Skip to content

cp consistency tests when destination parent doesn't exist #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2020
Merged

cp consistency tests when destination parent doesn't exist #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,25 @@ module TestPaths
@test_throws ArgumentError cp(ps.foo, ps.qux / "foo")
cp(ps.foo, ps.qux / "foo"; force=true)
rm(ps.qux / "foo"; recursive=true)

@testset "non-existent destination parent" begin
# Test consistency with `cp` (e.g., destination parent must exist)
dest = ps.root / "non-existent" / "destination"

# The base behaviour can only be tested on system paths.
if isa(dest, SystemPath)
if VERSION >= v"1.2" # Error type changed in Julia 1.2
@test_throws ProcessFailedException run(`cp -r $(ps.foo) $dest`)
else
@test_throws ErrorException run(`cp -r $(ps.foo) $dest`)
end

@test_throws SystemError cp(string(ps.foo), string(dest))
end

# TODO: Use a more specific error type
@test_throws ErrorException cp(ps.foo, dest)
end
end
end

Expand Down Expand Up @@ -731,6 +750,15 @@ module TestPaths
rm(tmp_src; recursive=true)
rm(tmp_dst; recursive=true)
end

@testset "non-existent destination parent" begin
# Test consistency with `cp` (e.g., destination parent must exist)
# See full `cp` comparison tests above
dest = ps.root / "non-existent" / "destination"

# TODO: Use a more specific error type
@test_throws ErrorException sync(ps.foo, dest)
end
end
end

Expand Down