Skip to content

Conversation

@rofinn
Copy link
Owner

@rofinn rofinn commented Apr 24, 2020

  • Document Filesystem aliases
  • Test consistency with Filesystem behaviour
  • Replace Path(fp, segments) with a more general Path(fp; overrides) constructor.

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #86 into master will increase coverage by 0.54%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   87.42%   87.96%   +0.54%     
==========================================
  Files          12       12              
  Lines        1034     1039       +5     
==========================================
+ Hits          904      914      +10     
+ Misses        130      125       -5     
Impacted Files Coverage Δ
src/system.jl 86.04% <63.63%> (+0.77%) ⬆️
src/path.jl 83.84% <80.00%> (-0.41%) ⬇️
src/aliases.jl 86.66% <100.00%> (+29.52%) ⬆️
src/test.jl 93.31% <100.00%> (ø)
src/posix.jl 85.00% <0.00%> (+7.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05435df...af850a4. Read the comment docs.

@rofinn rofinn merged commit 676bd8a into master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants