Possibility to set default file name to write to using nwsaveas #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerwang
added a commit
that referenced
this pull request
Sep 5, 2013
Possibility to set default file name to write to using nwsaveas
|
Cool. thanks! Please add yourself to the AUTHORS file in node-webkit repo. |
rogerwang
pushed a commit
that referenced
this pull request
Sep 26, 2013
…w from WebKit This change covers a set of smaller fixes that were landed in WebKit regarding to shape-inside on regions and content overflow from shape-inside. Merged revisions: - #1 http://trac.webkit.org/changeset/148975 - #2 http://trac.webkit.org/changeset/149857 - #3 http://trac.webkit.org/changeset/150027 - #4 http://trac.webkit.org/changeset/150375 - #5 http://trac.webkit.org/changeset/150478 - #6 http://trac.webkit.org/changeset/151570 - #7 http://trac.webkit.org/changeset/151652 - #8 http://trac.webkit.org/changeset/151703 - #9 http://trac.webkit.org/changeset/152772 - #10 http://trac.webkit.org/changeset/152904 - #11 http://trac.webkit.org/changeset/152906 - #12 http://trac.webkit.org/changeset/152925 - #13 http://trac.webkit.org/changeset/153053 R=eric@chromium.org BUG=262269 Review URL: https://chromiumcodereview.appspot.com/19865002 git-svn-id: svn://svn.chromium.org/blink/trunk@155098 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Sep 26, 2013
Shapes's polygon tests didn't run because of a typo and some missing js include. Merged revisions: - #1 http://trac.webkit.org/changeset/153338 - #2 http://trac.webkit.org/changeset/153350 Review URL: https://chromiumcodereview.appspot.com/20489004 git-svn-id: svn://svn.chromium.org/blink/trunk@155102 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
added a commit
that referenced
this pull request
Sep 26, 2013
or debug callback can't get the listener. Fix nwjs/nw.js#719 #0 WebCore::InspectorDebuggerAgent::didPause (this=0x7ffff7ee8800, scriptState=0x192e07eebb10, callFrames=..., exception=...) at ../../third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp:682 #1 0x0000000003665f7e in WebCore::ScriptDebugServer::breakProgram ( this=0x7ffff7ee8260, executionState=..., exception=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:425 #2 0x0000000003666ceb in WebCore::ScriptDebugServer::handleV8DebugEvent ( this=0x7ffff7ee8260, eventDetails=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:503 #3 0x0000000003666012 in WebCore::ScriptDebugServer::v8DebugEventCallback ( eventDetails=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:435 #4 0x0000000000f7ecb3 in v8::internal::Debugger::CallCEventCallback ( this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=..., client_data=0x0) at ../../v8/src/debug.cc:2953 #5 0x0000000000f7ebf9 in v8::internal::Debugger::CallEventCallback ( this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=..., client_data=0x0) at ../../v8/src/debug.cc:2932 #6 0x0000000000f7eabd in v8::internal::Debugger::ProcessDebugEvent ( this=0x7ffff7eec520, event=v8::Break, event_data=..., auto_continue=false) at ../../v8/src/debug.cc:2909 #7 0x0000000000f7e24d in v8::internal::Debugger::OnDebugBreak ( this=0x7ffff7eec520, break_points_hit=..., auto_continue=false) at ../../v8/src/debug.cc:2750 #8 0x0000000000f7836f in v8::internal::Debug::Break (this=0x7ffff7eecc20, args=...) at ../../v8/src/debug.cc:992 #9 0x0000000000f787a8 in v8::internal::__RT_impl_Debug_Break (args=..., isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1062 #10 0x0000000000f78769 in v8::internal::Debug_Break (args_length=0, args_object=0x7fffffff8248, isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1061
rogerwang
pushed a commit
that referenced
this pull request
Dec 21, 2013
Until (1) a transaction ends or (2) a cursor hits the end of its range, an IDBRequest holds on to an IDBCursor as its result. Per spec, calling continue() or advance() on the cursor re-uses the same IDBRequest, requiring a reference cycle. Previously, the cycle was broken explicitly on either of those two conditions, but until that time a cursor-request pair would "leak", holding on to potentially large script value results. This patch makes both classes RefCountedBase::deref() and check to see if they have a partner object and both refcounts are 1. If so, the cycle is broken. Special case cruft for condition #1 is removed to simplify the code - just rely on GC to reclaim the objects if necessary. R=alecflett@chromium.org,dgrogan@chromium.org BUG=225860 Review URL: https://chromiumcodereview.appspot.com/23653024 git-svn-id: svn://svn.chromium.org/blink/trunk@157382 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
added a commit
that referenced
this pull request
Dec 21, 2013
or debug callback can't get the listener. Fix nwjs/nw.js#719 #0 WebCore::InspectorDebuggerAgent::didPause (this=0x7ffff7ee8800, scriptState=0x192e07eebb10, callFrames=..., exception=...) at ../../third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp:682 #1 0x0000000003665f7e in WebCore::ScriptDebugServer::breakProgram ( this=0x7ffff7ee8260, executionState=..., exception=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:425 #2 0x0000000003666ceb in WebCore::ScriptDebugServer::handleV8DebugEvent ( this=0x7ffff7ee8260, eventDetails=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:503 #3 0x0000000003666012 in WebCore::ScriptDebugServer::v8DebugEventCallback ( eventDetails=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:435 #4 0x0000000000f7ecb3 in v8::internal::Debugger::CallCEventCallback ( this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=..., client_data=0x0) at ../../v8/src/debug.cc:2953 #5 0x0000000000f7ebf9 in v8::internal::Debugger::CallEventCallback ( this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=..., client_data=0x0) at ../../v8/src/debug.cc:2932 #6 0x0000000000f7eabd in v8::internal::Debugger::ProcessDebugEvent ( this=0x7ffff7eec520, event=v8::Break, event_data=..., auto_continue=false) at ../../v8/src/debug.cc:2909 #7 0x0000000000f7e24d in v8::internal::Debugger::OnDebugBreak ( this=0x7ffff7eec520, break_points_hit=..., auto_continue=false) at ../../v8/src/debug.cc:2750 #8 0x0000000000f7836f in v8::internal::Debug::Break (this=0x7ffff7eecc20, args=...) at ../../v8/src/debug.cc:992 #9 0x0000000000f787a8 in v8::internal::__RT_impl_Debug_Break (args=..., isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1062 #10 0x0000000000f78769 in v8::internal::Debug_Break (args_length=0, args_object=0x7fffffff8248, isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1061
GnorTech
pushed a commit
that referenced
this pull request
Jun 3, 2014
This switches fastMalloc to PartitionAlloc for Android. Previously, we only used PartitionAlloc for fastMalloc on Mac OS X. According to primiano's measurements, this CL should improve PLT performance on Android by 7%. See referenced bug for details. alexa_us on N10 with default alloc (without # ms/page PSS Dirty #1 227.6 60410 44904 #2 226.1 61547 46008 #3 222.4 55595 40072 #4 224.2 57293 41728 AVG 225.1 58711 43178 alexa_us on N10 with partalloc # ms/page PSS Dirty #1 204.68 54862 39456 #2 208.73 59240 43844 #3 208.57 55164 39788 #4 217.28 58280 42904 AVG 209.81 56886 41498 BUG=312725 R=tonyg@chromium.org Review URL: https://codereview.chromium.org/148013010 git-svn-id: svn://svn.chromium.org/blink/trunk@166271 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Jun 3, 2014
The deprecated MediaStreamTrack.getSources() will be removed later. This patch contains almost everything except .idl files which means that this is "dead" code which will not affect anything. Patch 2 will introduce mock support for getMediaDevices. And finally the third patch will add tests and idl files. BUG=338511 Review URL: https://codereview.chromium.org/135363004 git-svn-id: svn://svn.chromium.org/blink/trunk@166370 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Jun 3, 2014
…mpatible to tcmalloc R=esprehn@chromium.org TEST=Compile Android build with Deep Memory Profiler support. Go to lenta.ru. Open some news pages. Should not crash. ********** Crash dump: ********** Build fingerprint: 'samsung/GT-I9100/GT-I9100:4.0.3/IML74K/XXLPQ:user/release-keys' pid: 3431, tid: 3444 >>> org.chromium.content_shell_apk:sandboxed_process1 <<< signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 00000039 Stack frame #00 pc 02263b44 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Abort in ../../third_party/tcmalloc/chromium/src/base/abort.cc:15 Stack frame #1 pc 0226ccd8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Log in ../../third_party/tcmalloc/chromium/src/internal_logging.cc:120 Stack frame #2 pc 0227584c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine InvalidFree in (null):0 Stack frame #3 pc 02277698 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free_with_callback in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1166 Stack frame #4 pc 02277898 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1209 Stack frame #5 pc 0229f914 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine tc_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1569 Stack frame #6 pc 0158af50 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine error in (null):0 Stack frame #7 pc 0158aff8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine normalErrorHandler in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:1305 Stack frame #8 pc 01166dac /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __xmlRaiseError in ../../third_party/libxml/src/error.c:572 Stack frame #9 pc 0116b7a8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlFatalErr in (null):0 Stack frame #10 pc 0117e424 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseTryOrFinish in ../../third_party/libxml/src/parser.c:11453 Stack frame #11 pc 0117ea88 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseChunk in ../../third_party/libxml/src/parser.c:11767 Stack frame #12 pc 0158891c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine parseChunk in (null):0 Stack frame #13 pc 01589da0 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine doWrite in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:876 Stack frame #14 pc 01589f3c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine append in ../../third_party/WebKit/Source/wtf/RefPtr.h:49 Stack frame #15 pc 00d07e70 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine setContent in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70 Stack frame #16 pc 015770bc /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXML in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70 Stack frame #17 pc 017bdd20 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetter in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:47 Stack frame #18 pc 017bddc8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetterCallback in gen/blink/bindings/V8XMLHttpRequest.cpp:219 Stack frame #19 pc 00eb86d8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Call in ../../v8/src/arguments.cc:110 Stack frame #20 pc 01024b5c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetPropertyWithCallback in ../../v8/src/objects.cc:443 Stack frame #21 pc 010304c8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:971 Stack frame #22 pc 010305dc /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:845 Stack frame #23 pc 00fb12f8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Load in ../../v8/src/ic.cc:875 Stack frame #24 pc 00fb1b78 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __RT_impl_LoadIC_Miss in ../../v8/src/ic.cc:2076 Stack frame #25 pc 00fb1bd0 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine LoadIC_Miss in (null):0 Review URL: https://codereview.chromium.org/143903018 git-svn-id: svn://svn.chromium.org/blink/trunk@166520 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Jun 3, 2014
Drive by: 1. The original mergeOrIntersect had a bug causing e.g. []x[1,2,3] produce [1,2,3]. 2. findFilesMatchingSearchRequest had a bug that relied on #1 and produced almost correct results. Both are fixed with this patch. R=pfeldman@chromium.org, vsevik@chromium.org Review URL: https://codereview.chromium.org/166703003 git-svn-id: svn://svn.chromium.org/blink/trunk@167282 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Jun 3, 2014
Revert 168384 as it caused a serious crash (top #1 crasher on mac). BUG=349842 > Use OwnPtrs for heap contains cache and persistent anchor. We were leaking the HeapContainsCache. > > R=haraken@chromium.org, vegorov@chromium.org > BUG=348629 > NOTRY=true > > Review URL: https://codereview.chromium.org/183683017 TBR=ager@chromium.org Review URL: https://codereview.chromium.org/180723022 git-svn-id: svn://svn.chromium.org/blink/trunk@168676 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Jun 3, 2014
Parameter "sampleRate" is not required for loadAudioResource(). There is FIXME in AudioBus.cpp in blink FIXME: the sampleRate parameter is ignored. It should be removed from the API. It will be consist of 3 steps. 1. Removing "sampleRate" in chrome which is called by blink. (included deprecated method) https://codereview.chromium.org/195043002/ 2. Removing "sampleRate" in blink. https://codereview.chromium.org/194753005/ 3. Removing deprecated method from #1 BUG=351284 Review URL: https://codereview.chromium.org/194753005 git-svn-id: svn://svn.chromium.org/blink/trunk@169188 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Jun 3, 2014
…dereview.chromium.org/183793002/) Reason for revert: Possibly causing content_browsertests EndToEnd to fail. See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio Output: [20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0) [20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28) BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x000000a593be base::debug::StackTrace::StackTrace() #1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f9c3e4ab4a0 <unknown> #3 0x7f9c3e55da43 __poll #4 0x7f9c42aabff6 <unknown> #5 0x7f9c42aac124 g_main_context_iteration #6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher() #7 0x000000a8e802 base::RunLoop::Run() #8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread() Original issue's description: > Make start/stop loading notifications per-frame > > Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly. > > This depends on https://codereview.chromium.org/180113003/ landing in chromium. > > BUG=347643 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192 TBR=abarth@chromium.org,japhet@chromium.org NOTREECHECKS=true NOTRY=true BUG=347643 Review URL: https://codereview.chromium.org/215533004 git-svn-id: svn://svn.chromium.org/blink/trunk@170218 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Jun 3, 2014
…ttps://codereview.chromium.org/215533004/) Reason for revert: r170192 was not a culprit. Original issue's description: > Revert of Make start/stop loading notifications per-frame (https://codereview.chromium.org/183793002/) > > Reason for revert: > Possibly causing content_browsertests EndToEnd to fail. > > See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio > > Output: > [20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0) > [20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28) > BrowserTestBase signal handler received SIGTERM. Backtrace: > #0 0x000000a593be base::debug::StackTrace::StackTrace() > #1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler() > #2 0x7f9c3e4ab4a0 <unknown> > #3 0x7f9c3e55da43 __poll > #4 0x7f9c42aabff6 <unknown> > #5 0x7f9c42aac124 g_main_context_iteration > #6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher() > #7 0x000000a8e802 base::RunLoop::Run() > #8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread() > > Original issue's description: > > Make start/stop loading notifications per-frame > > > > Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly. > > > > This depends on https://codereview.chromium.org/180113003/ landing in chromium. > > > > BUG=347643 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192 > > TBR=abarth@chromium.org,japhet@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=347643 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170218 TBR=abarth@chromium.org,japhet@chromium.org,enne@chromium.org NOTREECHECKS=true NOTRY=true BUG=347643 Review URL: https://codereview.chromium.org/216083002 git-svn-id: svn://svn.chromium.org/blink/trunk@170248 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Sep 25, 2014
…of a pointer (https://codereview.chromium.org/209713003/) Also reverting dependent patch https://codereview.chromium.org/213543004 Reason for revert: Likely to have caused memory leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1 (1) Direct leak of 32 byte(s) in 1 object(s) allocated from: #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56 #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108 #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16 #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 (2) Indirect leak of 40 byte(s) in 1 object(s) allocated from: #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22 #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 (3) Indirect leak of 24 byte(s) in 1 object(s) allocated from: #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75 #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533 #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549 #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125 #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175 #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 Original issue's description: > Make DOMWrapperWorld::current() return a reference instead of a pointer > > Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer. > > BUG=341032 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261 TBR=jochen@chromium.org,dcarney@chromium.org,abarth@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=341032 Review URL: https://codereview.chromium.org/217053007 git-svn-id: svn://svn.chromium.org/blink/trunk@170357 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Sep 25, 2014
This is a revert of the revert of r170261. r170261 was reverted because it introduced new memory leaks, but the leaks were false-positive. > Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (https://codereview.chromium.org/209713003/) > > Also reverting dependent patch https://codereview.chromium.org/213543004 > > Reason for revert: > Likely to have caused memory leaks: > http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1 > > (1) > Direct leak of 32 byte(s) in 1 object(s) allocated from: > #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 > #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56 > #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108 > #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16 > #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 > > (2) > Indirect leak of 40 byte(s) in 1 object(s) allocated from: > #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 > #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22 > #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 > #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 > > (3) > Indirect leak of 24 byte(s) in 1 object(s) allocated from: > #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75 > #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533 > #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549 > #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125 > #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175 > #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 > > Original issue's description: > > Make DOMWrapperWorld::current() return a reference instead of a pointer > > > > Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer. > > > > BUG=341032 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261 > > TBR=jochen@chromium.org,dcarney@chromium.org,abarth@chromium.org,haraken@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=341032 > > Review URL: https://codereview.chromium.org/217053007 TBR=enne@chromium.org Review URL: https://codereview.chromium.org/218813002 git-svn-id: svn://svn.chromium.org/blink/trunk@170424 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Sep 25, 2014
This is the final patch in a three-part series towards early termination of flings when scrolling is impossible, cleaning up now unused portions of the WebGestureCurveTarget interface. Blink patch (#1) https://codereview.chromium.org/139493003/ Chromium patch (#2): https://codereview.chromium.org/136173004/ Review URL: https://codereview.chromium.org/217893004 git-svn-id: svn://svn.chromium.org/blink/trunk@170887 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Sep 25, 2014
…nd shorthand background-repeat serialization did not handle initial keyword values in background-repeat value lists. Initial values in value lists are introduced by setting the background shorthand to multiple background values while omitting background-repeat properties. Example: background: url(#1), url(#2), url(#3); The background-repeat gets stored internally as "initial, initial, initial". This patch updates StylePropertySerializer::backgroundRepeatPropertyValue() to handle this case correctly. BUG=378167 Review URL: https://codereview.chromium.org/303993003 git-svn-id: svn://svn.chromium.org/blink/trunk@175261 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Sep 25, 2014
This ctor is expected to be added to the spec: w3c/ServiceWorker#192 Eventually we'll also have ctors for String, Stream, and ArrayBuffer bodies. Multi-sided patch to implement blob-type fetch event response bodies: #1: blink-side, THIS PATCH #2: chromium-side: https://codereview.chromium.org/304153015/ #3: blink-side: https://codereview.chromium.org/304233017 BUG=379074 Review URL: https://codereview.chromium.org/307063002 git-svn-id: svn://svn.chromium.org/blink/trunk@175350 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Sep 25, 2014
…//codereview.chromium.org/312683005/) Reason for revert: This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905 BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace() #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f2c232cd4a0 \u003Cunknown> #3 0x7f2c2337f313 __poll #4 0x7f2c240b6036 \u003Cunknown> #5 0x7f2c240b6164 g_main_context_iteration #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run() #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler() #8 0x7f2c2a2f69d8 base::RunLoop::Run() #9 0x00000466bd59 content::RunThisRunLoop() #10 0x00000466c1b8 content::MessageLoopRunner::Run() #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle() #12 0x0000011fdf00 MediaBrowserTest::RunTest() #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage() #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage() #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange() #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread() ... Please look into it. An alterate possible candidate is https://codereview.chromium.org/327553002 but I think that's less likely. Original issue's description: > IDL: Support optional argument default value syntax > > Adds support for parsing default values of different types, but > only handles null default values when generating code. > > Replaces existing > > [Default=Null] optional SomeInterface arg > [Default=NullString] optional DOMString arg > > with the now equivalent > > optional SomeInterface arg = null > optional DOMString arg = null > > in IDL files, and drops support for those [Default] attributes. > > No changes to generated code. > > BUG=258153 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200 TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=258153 Review URL: https://codereview.chromium.org/339683002 git-svn-id: svn://svn.chromium.org/blink/trunk@176220 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Sep 25, 2014
…ax (https://codereview.chromium.org/339683002/) Reason for revert: Revert the revert because the bot went green even without this revert, and other bots had no trouble. Original issue's description: > Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/) > > Reason for revert: > This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905 > > BrowserTestBase signal handler received SIGTERM. Backtrace: > #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace() > #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #2 0x7f2c232cd4a0 \u003Cunknown> > #3 0x7f2c2337f313 __poll > #4 0x7f2c240b6036 \u003Cunknown> > #5 0x7f2c240b6164 g_main_context_iteration > #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run() > #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler() > #8 0x7f2c2a2f69d8 base::RunLoop::Run() > #9 0x00000466bd59 content::RunThisRunLoop() > #10 0x00000466c1b8 content::MessageLoopRunner::Run() > #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle() > #12 0x0000011fdf00 MediaBrowserTest::RunTest() > #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage() > #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage() > #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange() > #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread() > ... > > Please look into it. An alterate possible candidate is https://codereview.chromium.org/327553002 but I think that's less likely. > > Original issue's description: > > IDL: Support optional argument default value syntax > > > > Adds support for parsing default values of different types, but > > only handles null default values when generating code. > > > > Replaces existing > > > > [Default=Null] optional SomeInterface arg > > [Default=NullString] optional DOMString arg > > > > with the now equivalent > > > > optional SomeInterface arg = null > > optional DOMString arg = null > > > > in IDL files, and drops support for those [Default] attributes. > > > > No changes to generated code. > > > > BUG=258153 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200 > > TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com > NOTREECHECKS=true > NOTRY=true > BUG=258153 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176220 TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=258153 Review URL: https://codereview.chromium.org/339723002 git-svn-id: svn://svn.chromium.org/blink/trunk@176231 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Sep 25, 2014
Currently, ViewportControl uses clientHeight of its main element to estimate visible viewport height. This falls shortly under the following scenario: 1. ViewportControl has its "stickToBottom" flag set to true and just scrolled to bottom as its "refresh" method got executed. Note, that this refresh has scheduled one more scroll as it "scrolls to bottom". 2. The "refresh" method call figured out that there's a necessity to render one more element in the beginning of viewport, and this new element happen to add a horizontal scroll to the console. 3. Another "refresh" method gets executed (it was scheduled in #1) 4. The method figures out that client height changed (due to added horizontal scroller), thus first element not needed any more and gets removed from viewport. 5. Goto #1. This change migrates from using clientHeight to using offsetHeight which doesn't change as horizontal scroller gets added or removed in result of viewport rendering. BUG=387465 Review URL: https://codereview.chromium.org/396853005 git-svn-id: svn://svn.chromium.org/blink/trunk@178422 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Sep 25, 2014
…lose.html (patchset #1 of https://codereview.chromium.org/460213002/) Reason for revert: Fixed by http://src.chromium.org/viewvc/blink?view=revision&revision=180139 Original issue's description: > LeakDetector: Add an expectation for resolve-after-window-close.html > > r179771 fixed the crash bug but it didn't fix the leak bug. > > BUG=400012 > TEST=n/a > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180028 TBR=hajimehoshi@chromium.org,kouhei@chromium.org NOTREECHECKS=true NOTRY=true BUG=400012 Review URL: https://codereview.chromium.org/475593003 git-svn-id: svn://svn.chromium.org/blink/trunk@180221 bbb929c8-8fbe-4397-9dbb-9b2b20218538
GnorTech
pushed a commit
that referenced
this pull request
Sep 25, 2014
…ction (patchset #1 of https://codereview.chromium.org/463063003/) Reason for revert: This CL added the assumption that Python will write the lextab.pyc file. If that's a wrong assumption, which seems to be the case in some situations, the result is that the cached_lex_yacc_tables target never becomes clean, which in turn means that all IDL files are recompiled on each build. The problem fixed by this CL was cosmetic only, so is not worth the risk. Original issue's description: > Add lextab.pyc as an output of the cached_lex_yacc_tables action > > The primary output is lextab.py, but since it is imported, Python also > writes lextab.pyc. Listing it too as an output means it won't be left > around by "ninja -t clean" (and not much else, I think.) > > Prior to the patch > https://codereview.chromium.org/425953002/ > the result of not having lextab.pyc listed as an output and running > "ninja -t clean" was a tree that would build correctly, but that would > always rerun all the IDL code generation scripts, and thus never become > "clean". > > BUG=397909 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180142 TBR=haraken@chromium.org,nbarth@chromium.org NOTREECHECKS=true NOTRY=true BUG=397909 Review URL: https://codereview.chromium.org/468743003 git-svn-id: svn://svn.chromium.org/blink/trunk@180329 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
referenced
this pull request
in jtg-gg/blink
Nov 14, 2014
or debug callback can't get the listener. Fix nwjs/nw.js#719 #0 WebCore::InspectorDebuggerAgent::didPause (this=0x7ffff7ee8800, scriptState=0x192e07eebb10, callFrames=..., exception=...) at ../../third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp:682 #1 0x0000000003665f7e in WebCore::ScriptDebugServer::breakProgram ( this=0x7ffff7ee8260, executionState=..., exception=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:425 nwjs#2 0x0000000003666ceb in WebCore::ScriptDebugServer::handleV8DebugEvent ( this=0x7ffff7ee8260, eventDetails=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:503 nwjs#3 0x0000000003666012 in WebCore::ScriptDebugServer::v8DebugEventCallback ( eventDetails=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:435 nwjs#4 0x0000000000f7ecb3 in v8::internal::Debugger::CallCEventCallback ( this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=..., client_data=0x0) at ../../v8/src/debug.cc:2953 nwjs#5 0x0000000000f7ebf9 in v8::internal::Debugger::CallEventCallback ( this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=..., client_data=0x0) at ../../v8/src/debug.cc:2932 nwjs#6 0x0000000000f7eabd in v8::internal::Debugger::ProcessDebugEvent ( this=0x7ffff7eec520, event=v8::Break, event_data=..., auto_continue=false) at ../../v8/src/debug.cc:2909 nwjs#7 0x0000000000f7e24d in v8::internal::Debugger::OnDebugBreak ( this=0x7ffff7eec520, break_points_hit=..., auto_continue=false) at ../../v8/src/debug.cc:2750 nwjs#8 0x0000000000f7836f in v8::internal::Debug::Break (this=0x7ffff7eecc20, args=...) at ../../v8/src/debug.cc:992 nwjs#9 0x0000000000f787a8 in v8::internal::__RT_impl_Debug_Break (args=..., isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1062 nwjs#10 0x0000000000f78769 in v8::internal::Debug_Break (args_length=0, args_object=0x7fffffff8248, isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1061
jtg-gg
referenced
this pull request
in jtg-gg/blink
Nov 14, 2014
or debug callback can't get the listener. Fix nwjs/nw.js#719 #0 WebCore::InspectorDebuggerAgent::didPause (this=0x7ffff7ee8800, scriptState=0x192e07eebb10, callFrames=..., exception=...) at ../../third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp:682 #1 0x0000000003665f7e in WebCore::ScriptDebugServer::breakProgram ( this=0x7ffff7ee8260, executionState=..., exception=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:425 nwjs#2 0x0000000003666ceb in WebCore::ScriptDebugServer::handleV8DebugEvent ( this=0x7ffff7ee8260, eventDetails=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:503 nwjs#3 0x0000000003666012 in WebCore::ScriptDebugServer::v8DebugEventCallback ( eventDetails=...) at ../../third_party/WebKit/Source/bindings/v8/ScriptDebugServer.cpp:435 nwjs#4 0x0000000000f7ecb3 in v8::internal::Debugger::CallCEventCallback ( this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=..., client_data=0x0) at ../../v8/src/debug.cc:2953 nwjs#5 0x0000000000f7ebf9 in v8::internal::Debugger::CallEventCallback ( this=0x7ffff7eec520, event=v8::Break, exec_state=..., event_data=..., client_data=0x0) at ../../v8/src/debug.cc:2932 nwjs#6 0x0000000000f7eabd in v8::internal::Debugger::ProcessDebugEvent ( this=0x7ffff7eec520, event=v8::Break, event_data=..., auto_continue=false) at ../../v8/src/debug.cc:2909 nwjs#7 0x0000000000f7e24d in v8::internal::Debugger::OnDebugBreak ( this=0x7ffff7eec520, break_points_hit=..., auto_continue=false) at ../../v8/src/debug.cc:2750 nwjs#8 0x0000000000f7836f in v8::internal::Debug::Break (this=0x7ffff7eecc20, args=...) at ../../v8/src/debug.cc:992 nwjs#9 0x0000000000f787a8 in v8::internal::__RT_impl_Debug_Break (args=..., isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1062 nwjs#10 0x0000000000f78769 in v8::internal::Debug_Break (args_length=0, args_object=0x7fffffff8248, isolate=0x7ffff7e80020) at ../../v8/src/debug.cc:1061
scheib
pushed a commit
to scheib/blink
that referenced
this pull request
Jan 27, 2015
…ttps://codereview.chromium.org/571563002/) Reason for revert: Had to revert this one because https://codereview.chromium.org/573553002/ is reverted Original issue's description: > Remove make-file-arrays.py script > > Removing the script used to generate the string arrays for blink. > > BUG=312586 > > R=jochen@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188397 TBR=jochen@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com NOTREECHECKS=true NOTRY=true BUG=312586 Review URL: https://codereview.chromium.org/854683002 git-svn-id: svn://svn.chromium.org/blink/trunk@188405 bbb929c8-8fbe-4397-9dbb-9b2b20218538
scheib
pushed a commit
to scheib/blink
that referenced
this pull request
Jan 27, 2015
…rect.html (patchset nwjs#1 id:1 of https://codereview.chromium.org/869023003/) Reason for revert: This expansion wasn't correct; the XP deps bot will pick up the XP expectations once they roll in to DEPS. Original issue's description: > Widening the test expectation for fetch-access-control-redirect.html > > It's also timing out on XP Deps. (What modifier I can use to cover it?) > > BUG=444493 > TBR=kochi > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188846 TBR=kochi@chromium.org,kinuko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=444493 Review URL: https://codereview.chromium.org/872603002 git-svn-id: svn://svn.chromium.org/blink/trunk@188849 bbb929c8-8fbe-4397-9dbb-9b2b20218538
scheib
pushed a commit
to scheib/blink
that referenced
this pull request
Jan 27, 2015
…alCapacity (patchset nwjs#1 id:1 of https://codereview.chromium.org/883573003/) Reason for revert: Appears to be causing crashes in browser tests due to bad LocalFrame casts: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20(dbg)/builds/5376/steps/content_browsertests/logs/KillingRendererClearsDescendantProxies Original issue's description: > PageAnimator: estimate number of documents and reserveInitialCapacity > > PageAnimator::serviceScriptedAnimation is called every frame. > The vector expansion should be kept minimal for performance. > > The CL adds reserveInitialCapacity to avoid dynamic expand. > > BUG=452351 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189003 TBR=dstockwell@chromium.org,haraken@chromium.org,kouhei@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452351 Review URL: https://codereview.chromium.org/880053002 git-svn-id: svn://svn.chromium.org/blink/trunk@189051 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
#1 id:1 of https://codereview.chromium.org/708713004/) Reason for revert: Seems to be the cause of assertion failures like: crash log for renderer (pid 30072): STDOUT: #CRASHED - renderer (pid 30072) STDERR: Xlib: extension "RANDR" missing on display ":9". STDERR: [30072:30072:1017/090946:3443219798580:ERROR:renderer_main.cc(227)] Running without renderer sandbox STDERR: [30090:30090:1017/090946:3443219850178:ERROR:renderer_main.cc(227)] Running without renderer sandbox STDERR: ASSERTION FAILED: !value || (value->isInitialValue()) STDERR: ../../third_party/WebKit/Source/core/css/CSSLineBoxContainValue.h(59) : const WebCore::CSSLineBoxContainValue* WebCore::toCSSLineBoxContainValue(const WebCore::CSSValue*) Example failing build: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28dbg%29/builds/19815 Please file bugs for changes like this in the future so there is a permanent record of any reverts and re-lands. Original issue's description: > Improve logic in ensureDefaultStyleSheetsForElement > > Improve logic in ensureDefaultStyleSheetsForElement, there > is no need for example to test namespace for Mathml if we > already established the element is an SVG element. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186262 TBR=esprehn@chromium.org,rob.buis@samsung.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/770103002 git-svn-id: svn://svn.chromium.org/blink/trunk@186272 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
The event is being deprecated in favor of using GestureScrollUpdate. All relevant LayoutTests are updated to use the new method available in EventSender. This patch is part of a series: patch #1: https://codereview.chromium.org/703983002 patch #2: https://codereview.chromium.org/729533003 patch #3: This CL BUG=416596 Review URL: https://codereview.chromium.org/732483003 git-svn-id: svn://svn.chromium.org/blink/trunk@186303 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…ecodes of background/border images (patchset #1 id:1 of https://codereview.chromium.org/766133002/) Reason for revert: This will re-land the original CL, as it appears to have no effect on the perf test referred to in BUG=437496 Original issue's description: > Revert of Timeline: fix URLs and owner elements for image decodes of background/border images (patchset #2 id:20001 of https://codereview.chromium.org/755633002/) > > Reason for revert: > Speculative revert to see whether this really could be a reson for https://code.google.com/p/chromium/issues/detail?id=437496 > > Original issue's description: > > Timeline: fix URLs and owner elements for image decodes of background/border images > > > > We rely on PaintImage events to provide context information available > > on the rendering level (image URLs and owning node id) for nested > > DecodeImage and ResizeImage events. However, we only had PaintImage > > emitted when painting an Image element. This adds similar events for > > images that are painted as backgrounds and borders. > > > > BUG=434905 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186030 > > TBR=chrishtr@chromium.org,yurys@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=434905 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186218 TBR=chrishtr@chromium.org,yurys@chromium.org NOTREECHECKS=true NOTRY=true BUG=434905 Review URL: https://codereview.chromium.org/768353002 git-svn-id: svn://svn.chromium.org/blink/trunk@186307 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…tchset #1 id:1 of https://codereview.chromium.org/738473003/) Reason for revert: possible cause of perf regression see http://crbug.com/436499 Original issue's description: > Inform Chrome client of changes to an input's datalist. > > This causes Chrome to update any already-visible datalist dropdowns when options are added or removed. > > BUG=428790 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185562 TBR=tkent@chromium.org NOTREECHECKS=true NOTRY=true BUG=428790 Review URL: https://codereview.chromium.org/777453002 git-svn-id: svn://svn.chromium.org/blink/trunk@186336 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…ion (patchset #1 id:1 of https://codereview.chromium.org/749283004/) Reason for revert: The original commit has been reverted. Original issue's description: > Asan: timeouts after enabling stack use-after-return detection > > NOTRY=true > TBR= > BUG=438499 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186416 TBR=pfeldman@chromium.org NOTREECHECKS=true NOTRY=true BUG=438499 Review URL: https://codereview.chromium.org/773193005 git-svn-id: svn://svn.chromium.org/blink/trunk@186436 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
… (patchset #1 id:1 of https://codereview.chromium.org/756823004/) Reason for revert: Two Nexus 4 tests started crashing after this change: ast/animation/request-animation-frame-callback-id.html svg/canvas/canvas-pattern-svg.html See eg http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fanimation%2Frequest-animation-frame-callback-id.html&testType=layout-tests First failure is here: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/23692 However the Nexus 4 bot is exhibiting other problems from build 23691 that might be related. So this is a speculative rollout. Original issue's description: > Do the early return when role is different than UnknownRole > > We do not need to call ariaRoleAttribute() to check whether current role > is different than UnknownRole. Just check m_ariaRole instead. > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186527 TBR=dmazzoni@chromium.org,k.czech@samsung.com NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/773213003 git-svn-id: svn://svn.chromium.org/blink/trunk@186566 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
https://codereview.chromium.org/782853002/) Reason for revert: A build fix has landed, so the revert is no longer necessary. Original issue's description: > Revert of Implement unset value handling (patchset #4 id:80001 of https://codereview.chromium.org/775153002/) > > Reason for revert: > This broke the Linux Oilpan Builder. > > Logs: http://build.chromium.org/p/chromium.perf/builders/Linux%20Oilpan%20Builder/builds/13454/steps/compile/logs/stdio#error1 > > BUG=439604 > > Original issue's description: > > Implement unset value handling > > > > This patch accepts unset as a valid CSS value and creates > > a CSSUnsetValue object for it. Then when resolving it the > > rules stated in below link are implemented: > > > > http://dev.w3.org/csswg/css-cascade/#valuedef-unset > > > > Add a test for the new behavior. > > > > BUG=431689 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186604 > > TBR=timloh@chromium.org,rob.buis@samsung.com > NOTREECHECKS=true > NOTRY=true > BUG=431689 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186627 TBR=timloh@chromium.org,rob.buis@samsung.com NOTREECHECKS=true NOTRY=true BUG=439604 Review URL: https://codereview.chromium.org/773483003 git-svn-id: svn://svn.chromium.org/blink/trunk@186637 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…ps://codereview.chromium.org/766183012/) Reason for revert: I think that this broke the following test on Linux MSAN: media/encrypted-media/encrypted-media-async-creation-with-gc-crash Here is the log: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_MSAN/results/layout-test-results/media/encrypted-media/encrypted-media-async-creation-with-gc-crash-log.txt Flakiness dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Fencrypted-media%2Fencrypted-media-async-creation-with-gc.html&testType=layout-tests Original issue's description: > Change EME IDL to use BufferSource > > Simplify the code by using a typedef and getting passed in a > DOMArrayPiece. > > BUG=224786 > TEST=existing EME tests pass > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186626 TBR=ddorwin@chromium.org,sandersd@chromium.org,jrummell@chromium.org NOTREECHECKS=true NOTRY=true BUG=224786 Review URL: https://codereview.chromium.org/782253002 git-svn-id: svn://svn.chromium.org/blink/trunk@186667 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…patchset #1 id:1 of https://codereview.chromium.org/797483003/) Reason for revert: Test plugins/js-from-destroy.html starts crashing on Mac. Flakiness Dashboard: http://goo.gl/YID0Ti Original issue's description: > Remove unneeded DocumentLoader null check in WindowProxy. > > BUG=none > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186983 TBR=haraken@chromium.org,dcarney@chromium.org,dcheng@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/794113005 git-svn-id: svn://svn.chromium.org/blink/trunk@187020 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…owProxy. (patchset #1 id:1 of https://codereview.chromium.org/794113005/) Reason for revert: The revert broke compilation everywhere. Original issue's description: > Revert of Remove unneeded DocumentLoader null check in WindowProxy. (patchset #1 id:1 of https://codereview.chromium.org/797483003/) > > Reason for revert: > Test plugins/js-from-destroy.html starts crashing on Mac. > Flakiness Dashboard: http://goo.gl/YID0Ti > > Original issue's description: > > Remove unneeded DocumentLoader null check in WindowProxy. > > > > BUG=none > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186983 > > TBR=haraken@chromium.org,dcarney@chromium.org,dcheng@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=none > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187020 TBR=haraken@chromium.org,dcarney@chromium.org,dcheng@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/804483002 git-svn-id: svn://svn.chromium.org/blink/trunk@187021 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…chset #1 id:1 of https://codereview.chromium.org/799013002/) Reason for revert: this patch is very unlikely to have caused that fallure, trying again Original issue's description: > Revert of convert generated bindings to handle symbols (patchset #2 id:20001 of https://codereview.chromium.org/797243002/) > > Reason for revert: > This patchset likely introduced a build failure: > > http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/70380 > > Original issue's description: > > convert generated bindings to handle symbols > > > > callbacks taking v8::String will be deprecated soon. additionally the new api will support removal of the Get/HasRealNamed.... checks. > > > > BUG= > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187028 > > TBR=dcarney@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187030 TBR=ellyjones@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/800973002 git-svn-id: svn://svn.chromium.org/blink/trunk@187046 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
… Animation::priority() instead. (patchset #1 id:1 of https://codereview.chromium.org/799533002/) Reason for revert: This CL breaks AnimationAnimationStackTest.ForwardsFillDiscarding unit test in Oilpan build. Original issue's description: > Remove unnecessary member SampledEffect::m_priority and use Animation::priority() instead. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187000 TBR=dstockwell@chromium.org,timloh@chromium.org,sigbjornf@opera.com NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/805753002 git-svn-id: svn://svn.chromium.org/blink/trunk@187130 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
https://codereview.chromium.org/798343002/) Reason for revert: The special casing for chrome: URLs in Blink is too hacky. Let's try to fix chrome: urls before branch cut. Original issue's description: > Disable parser yielding for chrome: urls > > Original fix by Pat Meenan <pmeenan@chromium.org>: > https://crrev.com/787253003/ > > A lot of the Chrome UI relies on javascript running after layout to > populate strings. Yielding in that case exposed the layout changes. > Ultimately it would be good to fix the UI as well to avoid reflows but > this allows us to keep the yielding for the general web and not regress > the Chrome UI. > > AUTHOR=pmeenan@chromium.org,kouhei@chromium.org > BUG=434974, 440771, 441716 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187235 TBR=pmeenan@chromium.org,haraken@chromium.org,dbeam@chromium.org BUG=434974, 440771, 441716 Review URL: https://codereview.chromium.org/794683004 git-svn-id: svn://svn.chromium.org/blink/trunk@187382 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…dereview.chromium.org/811143002/) Reason for revert: We need to rebaseline this again together with the base test (marked NeedsRebaseline in http://src.chromium.org/viewvc/blink?view=rev&rev=187403). Original issue's description: > Auto-rebaseline for r187299 > > http://src.chromium.org/viewvc/blink?view=revision&revision=187299 > > BUG=381919 > TBR=jianli@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187388 TBR=jianli@chromium.org,alancutter@chromium.org NOTREECHECKS=true NOTRY=true BUG=381919 Review URL: https://codereview.chromium.org/784283005 git-svn-id: svn://svn.chromium.org/blink/trunk@187409 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…#1 id:1 of https://codereview.chromium.org/772753002/) Reason for revert: Trybot failure was likely a flake. I cannot reproduce it locally or on a trybot. Original issue's description: > Revert of Ignore alt+tab in defaultTabEventHandler (patchset #3 id:40001 of https://codereview.chromium.org/759813003/) > > Reason for revert: > Seems to have broken interactive_ui_tests on Windows, blocking Blink rolls. See: > http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/builds/15935 > > > Original issue's description: > > Ignore alt+tab in defaultTabEventHandler > > > > As discussed on > > https://groups.google.com/a/chromium.org/d/topic/blink-dev/9NRKOaJhElQ/discussion. > > > > The Chrome OS window manager helpfully (?) forwards all key press > > events, including alt+tab, when an app is full screen with the > > expectation that the web contents will ignore the event and send it back > > to the window manager if it is not interested in it. However, this > > never happens in practice because the event gets default handled in > > blink if it is ignored by the web contents. > > > > The reason this isn't a problem for Chrome is that it checks if the key > > press event is a special key combination and handles it directly without > > passing it on to the web contents if it is (see > > BrowserView::PreHandleKeyboardEvent). Chrome also explicitly skips the > > check if the current Browser object is an app, which is why this problem > > only manifests itself for apps in full screen mode. > > > > We can't change the check in BrowserView::PreHandleKeyboardEvent because > > the current behavior was put in so that Chrome Remote Desktop users > > would be able to forward alt+tab to their remote machines and adding the > > check for apps would break CRD. An alternative is have apps detect > > alt+tab and call preventDefault() on it so that the event falls through > > to the window manager. This is also not great because we don't want > > apps to deal with the details of the chrome os window manager and using > > preventDefault() to prevent the default browser action so that the > > default window manager action can be taken instead is a little weird to > > think about. > > > > The only option left is to fix blink's default tab handler to ignore > > alt+tab events. On Mac OSX, alt+tab (or option+tab) is a shortcut whose > > behavior is governed by a system-wide setting. We don't actually > > respect this setting but that is separate issue. On all other > > platforms, we can safely ignore alt+tab and allow the event to fall back > > to the window manager. > > > > BUG=436670 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186266 > > TBR=thakis@chromium.org,chirantan@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=436670 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186277 TBR=thakis@chromium.org,kbr@chromium.org BUG=436670 Review URL: https://codereview.chromium.org/798333004 git-svn-id: svn://svn.chromium.org/blink/trunk@187424 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…ion-mark.html as failed on XP (patchset #1 id:1 of https://codereview.chromium.org/812233002/) Reason for revert: The test passed now on XP. Original issue's description: > Mark virtual/slimmingpaint/fast/text/line-break-after-question-mark.html > as failed on XP > > TBR=alancutter@chromium.org > NOTRY=true > NOTREECHECKS=true > BUG=425345 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187414 TBR=alancutter@chromium.org NOTREECHECKS=true NOTRY=true BUG=425345 Review URL: https://codereview.chromium.org/818453002 git-svn-id: svn://svn.chromium.org/blink/trunk@187483 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…ired (patchset #1 id:1 of https://codereview.chromium.org/823773003/) Reason for revert: Makes ASAN bots red. STDERR: ==8== WARNING: MemorySanitizer: use-of-uninitialized-value STDERR: #0 0x7f4ebe7c540e in blink::DOMTimer::fired() third_party/WebKit/Source/core/frame/DOMTimer.cpp:168:9 STDERR: #1 0x7f4ec5bc8b4c in blink::ThreadTimers::sharedTimerFiredInternal() third_party/WebKit/Source/platform/ThreadTimers.cpp:137:9 STDERR: #2 0x7f4ec5bc7fef in blink::ThreadTimers::sharedTimerFired() third_party/WebKit/Source/platform/ThreadTimers.cpp:107:5 STDERR: #3 0x7f4ec451bae7 in Run base/callback.h:396:12 STDERR: #4 0x7f4ec451bae7 in base::Timer::RunScheduledTask() base/timer/timer.cc:211:0 Original issue's description: > Oilpan: Remove redundant LifecycleObserver from DOMTimer::fired > > It is redundant to create a LifecycleObserver in DOMTimer::fired, because DOMTimer is an ActiveDOMObject and thus it can just peek executionContext() to know whether its associated ExecutionContext is already gone or not. > > BUG=340522 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187649 NOTRY=true TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com,haraken@chromium.org BUG=340522 Review URL: https://codereview.chromium.org/821313002 git-svn-id: svn://svn.chromium.org/blink/trunk@187668 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…ke hittest (patchset #1 id:1 of https://codereview.chromium.org/826103002/) Reason for revert: Speculative revert for Issue 445410: 199.3%-223.4% regression in blink_perf.svg at 309693:309695. BUG=445410 Original issue's description: > Eliminate FloatRect::inflate() calls for simple <rect> stroke hittest > > In RenderSVGRect::shapeDependentStrokeContains(), eliminate calls to > inflate(). Utilize rect symmetry to simplify the hit testing calculations. > > This is a follow-up to http://src.chromium.org/viewvc/blink?view=rev&rev=187728 > > BUG=350338 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187730 TBR=pdr@chromium.org,fs@opera.com,ed@opera.com,dtrebbien@gmail.com NOTREECHECKS=true NOTRY=true BUG=350338 Review URL: https://codereview.chromium.org/817353004 git-svn-id: svn://svn.chromium.org/blink/trunk@187755 bbb929c8-8fbe-4397-9dbb-9b2b20218538
rogerwang
pushed a commit
that referenced
this pull request
Jan 28, 2015
…e (patchset #1 id:1 of https://codereview.chromium.org/836863002/) Reason for revert: trailing_whitespace_wrapping.html is crashing on Mac10.6 (dbg) http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Ftext%2Ftrailing_whitespace_wrapping.html%2Cvirtual%2Fantialiasedtext%2Ffast%2Ftext%2Ftrailing_whitespace_wrapping.html%2Cvirtual%2Fslimmingpaint%2Ffast%2Ftext%2Ftrailing_whitespace_wrapping.html Example: 22:23:47.008 3912 worker/4 fast/text/trailing_whitespace_wrapping.html crashed, (stderr lines): 22:23:47.008 3912 Assertion failed: (bool (status_and & kCTRunStatusRightToLeft) == backward), function _hb_coretext_shape, file ../../third_party/harfbuzz-ng/src/hb-coretext.cc, line 989. 22:23:47.009 3881 [30380/38782] fast/text/trailing_whitespace_wrapping.html failed unexpectedly (renderer crashed [pid=6953]) Original issue's description: > Add tab support to RenderBlockLineLayout::stripTrailingSpace > > Change RenderBlockLineLayout::stripTrailingSpace to measure the width of > the first trailing white-space character instead of always assuming it's > a space character. This fixes a bug where we wrap text unnecessarily for > elements with a trailing tab character as we correctly measure the right > character (tab) when computing the preferred with but subtract the width > of a space character in stripTrailingSpace. > > R=pdr@chromium.org > BUG=444544 > TEST=fast/text/trailing_whitespace_wrapping.html > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187878 TBR=pdr@chromium.org,eae@chromium.org NOTREECHECKS=true NOTRY=true BUG=444544 Review URL: https://codereview.chromium.org/836103002 git-svn-id: svn://svn.chromium.org/blink/trunk@187897 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
referenced
this pull request
in jtg-gg/blink
Jul 31, 2015
…n computeIsInertOrAriaHidden (patchset #1 id:1 of https://codereview.chromium.org/1058313002/) Reason for revert: Failed Chromium bots Original issue's description: > No need to recompute inert while walking the parent chain in computeIsInertOrAriaHidden. > > Node::nodeIsInert already walks the parent chain: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/dom/Node.cpp&q=Node.cpp&sq=package:chromium&l=787 > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193146 TBR=dmazzoni@chromium.org,dtseng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1064503002 git-svn-id: svn://svn.chromium.org/blink/trunk@193147 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
referenced
this pull request
in jtg-gg/blink
Jul 31, 2015
…ble position. (patchset #1 id:1 of https://codereview.chromium.org/897633002/) Reason for revert: Revert for now until the fix is ready. Will also be reverted on release branch. Original issue's description: > RenderFlexibleBox should be treated as a candidate for visible position. > > Visible selection in an editable area is recalculated whenever an inner value of div is changed. > If the inner value is empty, the visible selection recalculated with DeleteSelectionCommand::m_endingPostion > is not correct. Because RenderBlockFlow is only considered but not RenderFlexibleBox in Position::isCandidate > so that a calculated ending VisiblePosition for an editable div having ‘display : flex’ goes weird > and VisibleSelection is empty accordingly. > > BUG=450617 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189482 TBR=sigbjornf@opera.com,rego@igalia.com,shivamidow@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=450617 Review URL: https://codereview.chromium.org/1060113002 git-svn-id: svn://svn.chromium.org/blink/trunk@193212 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
referenced
this pull request
in jtg-gg/blink
Jul 31, 2015
https://codereview.chromium.org/1062133002/) Reason for revert: Breaks content_browsertests with ASSERTION FAILED: StackFrameDepth::isSafeToRecurse(): https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/12077/steps/browser_tests/logs/stdio Original issue's description: > Oilpan: Make StackFrameDepth a singleton > > StackFrameDepth is used as a singleton in Visitor.h. > So this CL makes StackFrameDepth a singleton in a more straightforward way. > As a consequence, we can remove Visitor.cpp. > > BUG=474458 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193273 TBR=oilpan-reviews@chromium.org,keishi@chromium.org,haraken@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474458 Review URL: https://codereview.chromium.org/1066173003 git-svn-id: svn://svn.chromium.org/blink/trunk@193303 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
referenced
this pull request
in jtg-gg/blink
Jul 31, 2015
…chset #1 id:1 of https://codereview.chromium.org/1060773002/) Reason for revert: The change was committed after the branch and I will create a change that will include this one to merge. Original issue's description: > [Streams] Make ReadableStreamReader NoInterfaceObject. > > BUG=393911 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193154 TBR=horo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=393911 Review URL: https://codereview.chromium.org/1064323002 git-svn-id: svn://svn.chromium.org/blink/trunk@193317 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
referenced
this pull request
in jtg-gg/blink
Jul 31, 2015
…chset #1 id:1 of https://codereview.chromium.org/1039503003/) Reason for revert: Per the bug, Factor 3 images are acceptable to libjpeg6b and users can even create them using its well-known cjpeg tool. Original issue's description: > Add helper to validate JPEG subsampling factors > > Use it to turn the invalid horizontal/vertical subsampling factor 3 to a > 1, which is fine for both the YUV decoding path (it won't turn on if any > of the component subsamplings is 3) and the normal JPEG decode path. > > TEST=Covered by the test added in r192900 > BUG=398235 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192980 TBR=sugoi@chromium.org,reveman@chromium.org,pdr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=398235 Review URL: https://codereview.chromium.org/1069083003 git-svn-id: svn://svn.chromium.org/blink/trunk@193326 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
referenced
this pull request
in jtg-gg/blink
Jul 31, 2015
…ject. (patchset #1 id:1 of https://codereview.chromium.org/1064323002/) Reason for revert: The plan mentioned at the revert description changed. Original issue's description: > Revert of [Streams] Make ReadableStreamReader NoInterfaceObject. (patchset #1 id:1 of https://codereview.chromium.org/1060773002/) > > Reason for revert: > The change was committed after the branch and I will create a change that will include this one to merge. > > > Original issue's description: > > [Streams] Make ReadableStreamReader NoInterfaceObject. > > > > BUG=393911 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193154 > > TBR=horo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=393911 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193317 TBR=horo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=393911 Review URL: https://codereview.chromium.org/1077003002 git-svn-id: svn://svn.chromium.org/blink/trunk@193505 bbb929c8-8fbe-4397-9dbb-9b2b20218538
ghostoy
pushed a commit
that referenced
this pull request
Sep 14, 2015
> Revert of RenderBlock::layoutPositionedObjects should use setNeedsPositionedMovementLayout (patchset #1 id:1 of https://codereview.chromium.org/414123006/) > > Reason for revert: > Reverting this change fixes stable blocking bug: https://crbug.com/413553 > > Original issue's description: > > RenderBlock::layoutPositionedObjects should use setNeedsPositionedMovementLayout > > > > This CL swiches RenderBlock::layoutPositionedObjects from using setNeedsLayout > > to setNeedsPositionedMovementLayout, as indicated by the FIXME comment and > > associated bug. The test failure mentioned in the bug is no longer a problem. > > > > BUG=350756 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179289 > > TBR=leviw@chromium.org,dsinclair@chromium.org,jchaffraix@chromium.org,abarth@chromium.org > BUG=350756,413553 > > Review URL: https://codereview.chromium.org/598503002 TBR=alancutter@chromium.org BUG=350756,413553,405830 Review URL: https://codereview.chromium.org/601053002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@182640 bbb929c8-8fbe-4397-9dbb-9b2b20218538
ghostoy
pushed a commit
that referenced
this pull request
Sep 14, 2015
> Revert of Ship image-rendering: pixelated to stable. (patchset #1 id:1 of https://codereview.chromium.org/396063007/) > > Reason for revert: > The bug affecting canvases also affects images that become compositor layers. Unshipping until it's fixed. > > Original issue's description: > > Ship image-rendering: pixelated to stable. > > > > This also adds the value to DevTools. > > > > Intent to Ship: > > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/zSasd2LL8Mc > > > > BUG=317991,106662,260739,134040 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178653 > > TBR=vsevik@chromium.org,eseidel@chromium.org,timloh@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=317991,106662,260739,134040 > > Review URL: https://codereview.chromium.org/604683003 TBR=jackhou@chromium.org Review URL: https://codereview.chromium.org/612273002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2125@182882 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request from nwjs/nw.js#626 and some more. Generally I need that myself.
Now you can propose default filename for user. Examples:
<input style="display:none" id="save-file-dialog" type="file" nwsaveas>User gets saveAs dialog without any proposed name
<input style="display:none" id="save-file-dialog" type="file" nwsaveas="test.txt">Note
nwsaveasattribute now has file name.<input style="display:none" id="save-file-dialog" type="file" nwsaveas="c:\dev\nw\test.txt">Note you still can use nwworkingdir and add new nwsaveas filename proposing (without path) — there is no any compability break.
Compiled and tested on windows 8. Hope you merge it.