#8 Adds Event Endpoint, Auditing entity #18

damini1994 · 2024-10-30T10:21:05Z

No description provided.

…ype enums

…pe, SeatTypeInShow, Vendor, Venue

...ackend/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/BmsMonolithApplication.java

...nd/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/controller/EventController.java

...a/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/common/entity/BaseAuditingEntity.java

...-my-show/backend/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/entity/Event.java

.../backend/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/audit/AuditAwareImpl.java

...show/backend/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/entity/EventShow.java

rohitnandi12 · 2024-10-31T06:18:06Z

...show/backend/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/entity/EventShow.java

+    private Event event;
+
+    @OneToMany(mappedBy = "show", cascade = CascadeType.ALL, fetch = FetchType.LAZY)
+    private List<SeatInShow> seatInShows;


@Builder.Default
private List seatInShows = new ArrayList<>();

...backend/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/entity/SeatTypeInShow.java

...my-show/backend/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/entity/Vendor.java

...-my-show/backend/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/entity/Venue.java

book-my-show/backend/java/bms-monolith/src/main/resources/application.yaml

...a/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/exception/GlobalExceptionHandler.java

...java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/service/impl/EventServiceImpl.java

...nd/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/repository/EventRepository.java

rohitnandi12 · 2024-10-31T09:55:32Z

...nd/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/repository/EventRepository.java

+@Repository
+public interface EventRepository extends JpaRepository<Event, UUID> {
+
+    @Query("SELECT e FROM Event e JOIN FETCH e.vendor JOIN FETCH e.venue JOIN FETCH e.eventType")


I think this is not required. Bydefault JPA will use Joins. We can test it by running the code and checking hibernate logs.

Right, it seems there is an issue with the entity mapping, resulting in an entity not found exception

...backend/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/service/IEventService.java

nareshthecoder · 2024-10-30T16:59:31Z

...java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/common/constants/BMSConstants.java

+
+    public static final String  STATUS_200 = "200";
+    public static final String  MESSAGE_200 = "Request processed successfully";
+    public static final String  EVENT_SUCCESS_MESSAGE = "Events fetched successfully";


we could use interface for constants , I am not sure creating constant in class

@nareshthecoder No, interface can be inherited and usually Interface in Java is used to define API not constants.

...nd/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/controller/EventController.java

nareshthecoder · 2024-10-31T05:44:17Z

...java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/service/impl/EventServiceImpl.java

+    @Override
+    public ApiListResponse<Event> getAllEvents(int page, int size) {
+        try {
+            Page<Event> eventsPage = eventRepository.findAllWithDetails(PageRequest.of(page, size));


do we need default sorting for fetching data ?

DTO is not required?

rohitnandi12 · 2024-11-03T16:49:49Z

...show/backend/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/entity/EventShow.java

+    @NotNull
    private Instant startDate;
+
+    @NotNull


@NotNull will enforce a not null check from the application side, but it will not create a NOT NULL constraint on the database end. Bothe has to be added.

What is missing here is the Request, Response, and DTO layers.
@NotNull and similar spring validation should be in Request layer

Entity should have @column(nullable = false)

rohitnandi12 · 2024-11-03T16:52:48Z

...d/java/bms-monolith/src/main/java/org/lbcc/bms/bms_monolith/repository/IEventRepository.java

+public interface IEventRepository extends JpaRepository<Event, UUID> {

-    @Query("SELECT e FROM Event e JOIN FETCH e.vendor JOIN FETCH e.venue JOIN FETCH e.eventType")
+    @Query("SELECT e FROM Event e JOIN FETCH e.vendor JOIN FETCH e.venue JOIN FETCH e.eventType ORDER BY e.startDate DESC")


This query is still not required. Just passing the pageable will do the job. @manytoone annotation are FetchType.Eager by default hence JPA will use joins to fetch data.

* #8 Adds init spring-boot project * #8 Adds Instant type jackson converter * #8 Adds ApiErrorResponse * #8 Adds ApiResponse * #8 Adds ApiListResponse * #8 Adds TestBaseAuditingEntity * Feature/8 user portal part 1 (#17) * #8 Adds init spring-boot project * #8 Adds Instant type jackson converter * #8 Adds ApiErrorResponse * #8 Adds ApiResponse * #8 Adds ApiListResponse * #8 Adds TestBaseAuditingEntity * #8 Adds Event Endpoint, Auditing entity (#18) * #8 Adds AuditingEntityListener * #8 Adds BookingStatus, Genre, OperationalStatus, VendorStatus, VenueType enums * #8 Add entities Event, EventShow, EventType, Seat, SeatInShow, SeatType, SeatTypeInShow, Vendor, Venue * #8 Add getAllEvents endpoints * #8 Add test cases for getAllEvents endpoints * Resolved reviewed comments * Resolved reviewed comments * #8 Resolved reviewed comments * Refactor code to events package * Adds response layer, fix test cases. Removes sonar lints --------- Co-authored-by: damini1994 <55175815+damini1994@users.noreply.github.com>

damini1994 added 5 commits October 30, 2024 15:47

#8 Adds AuditingEntityListener

1d6ee5f

#8 Adds BookingStatus, Genre, OperationalStatus, VendorStatus, VenueT…

c5afdda

…ype enums

#8 Add entities Event, EventShow, EventType, Seat, SeatInShow, SeatTy…

fd28788

…pe, SeatTypeInShow, Vendor, Venue

#8 Add getAllEvents endpoints

790abb8

#8 Add test cases for getAllEvents endpoints

1e4e32a

rohitnandi12 changed the title ~~#8 Adds AuditingEntityListener~~ #8 Adds Event Endpoint, Auditing entity Oct 30, 2024

rohitnandi12 requested changes Oct 30, 2024

View reviewed changes

rohitnandi12 requested changes Oct 31, 2024

View reviewed changes

damini1994 added 3 commits November 3, 2024 00:16

Resolved reviewed comments

1d5c440

Resolved reviewed comments

e5484b1

#8 Resolved reviewed comments

5eb1342

nareshthecoder reviewed Nov 3, 2024

View reviewed changes

rohitnandi12 requested changes Nov 3, 2024

View reviewed changes

rohitnandi12 merged commit 01e77b4 into rohitnandi12:feature/8-user-portal-part-1 Nov 9, 2024

#8 Adds Event Endpoint, Auditing entity #18

#8 Adds Event Endpoint, Auditing entity #18

Uh oh!

Conversation

damini1994 commented Oct 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants