Add test case with control character #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mox-worker item #3656 happens because there is a \x13 control character in the source map json. It happens when the angular-1.4.5.js source content is included in the source map, but strangely in the source map there is a \x13 character on the position where there is a \xe2\x80\x93 in the original source. In the test case I added a js source containing both characters, minified it by `uglifyjs control_character.js -m --source-map includeSources -o control_character.min.js` and load the source map as a json. It succeeds, because the minification escaped the control character properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mox-worker item #3656 happens because there is a \x13 control character in the source map json.
It happens when the angular-1.4.5.js source content is included in the source map, but strangely in the source map there is a \x13 character on the position where there is a \xe2\x80\x93 in the original source.
In the test case I added a js source containing both characters, minified it by
uglifyjs control_character.js -m --source-map includeSources -o control_character.min.jsand load the source map as a json. It succeeds, because the minification escaped the control character properly.
See more in ch54099