Fix type definitions and component definitions #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes type definitions and component definitions by updating references from the old recorder module to the new replay module across the codebase. The changes ensure consistency between the module exports and their usage in examples.
- Updates CommonJS export to reference
replay.jsinstead ofrecorder.js - Updates all example files to import and use
replaycomponent instead ofrecorder - Maintains consistent naming convention across all component registration calls
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/browser/replay/replay.cjs | Updates CommonJS module export to reference replay.js |
| examples/webpack-require/src/index.js | Updates component import and registration from recorder to replay |
| examples/react-ts-components/src/rollbar.ts | Updates TypeScript example to use replay component |
| examples/react-js-components/src/rollbar.js | Updates React JS example to use replay component |
| examples/node-components/src/test.js | Updates Node.js test file to use replay component |
| examples/node-components/src/index.ts | Updates Node.js TypeScript example to use replay component |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
waltjones
reviewed
Oct 14, 2025
| ): void; | ||
| start(): this; | ||
| stop(): this; | ||
| clear(): void; |
There was a problem hiding this comment.
This file can be deleted since it's no longer the component.
There was a problem hiding this comment.
It's used by the IDE's own internal TS, I find it useful, that's why I didn't remove it. I did remove the cjs file, tho.
waltjones
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
recorderrecorderComponentType of change