Fix Angular example build failure + re-enable CI validation #1377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fixes the Angular example build failure and re-enables CI example validation by updating Angular packages and fixing server-side bootstrap function compatibility with Angular 19.2.x SSR requirements.
- Updated Angular example server bootstrap function to accept the required
BootstrapContextparameter - Upgraded all Angular packages from version 19.0.x to 19.2.x with tilde version constraints
- Re-enabled CI validation of examples that was previously disabled
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/angular/src/main.server.ts | Added BootstrapContext parameter to fix SSR compatibility |
| examples/angular/package.json | Updated Angular packages to version 19.2.x |
| .github/workflows/ci.yml | Re-enabled example validation in CI workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
brianr
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Important
CI validation of examples has been reactivated
The Angular example was failing to build with the error:
Angular 19.2.x introduced a requirement for server-side bootstrap functions to accept a
BootstrapContextparameter when using SSR with prerendering.Fixed the Angular example by modernizing and fixed the minor version of all angular packages.