Skip to content

feat: add ambiguous export error#397

Closed
underfin wants to merge 6 commits intoadd-missing-exportfrom
12-26-feat_add_ambiguous_export_error
Closed

feat: add ambiguous export error#397
underfin wants to merge 6 commits intoadd-missing-exportfrom
12-26-feat_add_ambiguous_export_error

Conversation

@underfin
Copy link
Copy Markdown
Contributor

@underfin underfin commented Dec 26, 2023

Description

Support give a warning for ambiguous export. Here is an example, the warning message is port from rollup.

[NAMESPACE_CONFLICT] Warning: Found ambiguous export.
   ╭─[main.js:1:10]
   │
 1 │ import { value } from "./foo";
   │          ──┬──  
   │            ╰──── "foo.js" re-exports "value" from one of the modules "b.js" and "a.js" (will be ignored).
───╯

Test Plan

Added.


@underfin
Copy link
Copy Markdown
Contributor Author

underfin commented Dec 26, 2023

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @underfin and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 force-pushed the 12-26-feat_add_ambiguous_export_error branch 2 times, most recently from 45b47d5 to 12ca49a Compare January 22, 2024 16:41
github-merge-queue Bot pushed a commit that referenced this pull request Jul 16, 2024
<!-- Thank you for contributing! -->
Closes #1621.
Closes #397.
<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->

---------

Co-authored-by: IWANABETHATGUY <974153916@qq.com>
Co-authored-by: Yunfei He <i.heyunfei@gmail.com>
@hyf0 hyf0 closed this in #1634 Jul 16, 2024
@Brooooooklyn Brooooooklyn deleted the 12-26-feat_add_ambiguous_export_error branch January 17, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants