fix(deps): add skipNodeModulesBundle dep subpath e2e tests and fix docs

sxzz · sxzz · commit deff72cc2585 · 2026-03-27T18:04:18.000+08:00
- Add e2e tests for skipNodeModulesBundle resolving dep subpaths (file and folder)
- Remove incorrect "skip resolving" wording from docs (it resolves but skips bundling)
- Fix typo in anchor: #deps-skipnodemodulebundle → #deps-skipnodemodulesbundle
diff --git a/docs/guide/how-it-works.md b/docs/guide/how-it-works.md
@@ -33,12 +33,12 @@ When you publish a library, your consumers install its `dependencies`, `peerDepe
 
 **Key options:**
 
-| Option                                                                               | What it does                                                                                                                                                                    |
-| ------------------------------------------------------------------------------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| [`deps.onlyBundle`](../options/dependencies.md#deps-onlybundle)                      | Whitelist of dependencies allowed to be bundled. Any unlisted dependency that ends up in the bundle causes an error. Useful for catching accidental inlining in large projects. |
-| [`deps.neverBundle`](../options/dependencies.md#deps-neverbundle)                    | Explicitly mark additional packages as external (never bundled).                                                                                                                |
-| [`deps.alwaysBundle`](../options/dependencies.md#deps-alwaysbundle)                  | Force specific packages to be bundled, even if they're in `dependencies`.                                                                                                       |
-| [`deps.skipNodeModulesBundle`](../options/dependencies.md#deps-skipnodemodulebundle) | Skip resolving and bundling everything from `node_modules`.                                                                                                                     |
+| Option                                                                                | What it does                                                                                                                                                                    |
+| ------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| [`deps.onlyBundle`](../options/dependencies.md#deps-onlybundle)                       | Whitelist of dependencies allowed to be bundled. Any unlisted dependency that ends up in the bundle causes an error. Useful for catching accidental inlining in large projects. |
+| [`deps.neverBundle`](../options/dependencies.md#deps-neverbundle)                     | Explicitly mark additional packages as external (never bundled).                                                                                                                |
+| [`deps.alwaysBundle`](../options/dependencies.md#deps-alwaysbundle)                   | Force specific packages to be bundled, even if they're in `dependencies`.                                                                                                       |
+| [`deps.skipNodeModulesBundle`](../options/dependencies.md#deps-skipnodemodulesbundle) | Skip bundling everything from `node_modules`.                                                                                                                                   |
 
 See [Dependencies](../options/dependencies.md) for details.
 
diff --git a/docs/options/dependencies.md b/docs/options/dependencies.md
@@ -38,7 +38,7 @@ export default defineConfig({
 
 ### `deps.skipNodeModulesBundle`
 
-If you want to **skip resolving and bundling all dependencies from `node_modules`**, you can enable `skipNodeModulesBundle`:
+If you want to **skip bundling all dependencies from `node_modules`**, you can enable `skipNodeModulesBundle`:
 
 ```ts [tsdown.config.ts]
 import { defineConfig } from 'tsdown'
@@ -50,7 +50,7 @@ export default defineConfig({
 })
 ```
 
-This will prevent `tsdown` from parsing and bundling any dependencies from `node_modules`, regardless of how they are referenced in your code.
+This will prevent `tsdown` from bundling any dependencies from `node_modules`, regardless of how they are referenced in your code.
 
 ::: warning
 `skipNodeModulesBundle` cannot be used together with `alwaysBundle`. These options are mutually exclusive.
@@ -155,7 +155,7 @@ The following top-level options are deprecated. Please migrate to the `deps` nam
   - Use `deps.onlyBundle` to whitelist dependencies allowed to be bundled, and throw an error for any others.
   - Use `deps.neverBundle` to mark specific dependencies as external.
   - Use `deps.alwaysBundle` to force specific dependencies to be bundled.
-  - Use `deps.skipNodeModulesBundle` to skip resolving and bundling all dependencies from `node_modules`.
+  - Use `deps.skipNodeModulesBundle` to skip bundling all dependencies from `node_modules`.
 - **Declaration Files**:
   - The bundling logic for declaration files is now the same as for JavaScript.
   - Use `resolver: 'tsc'` for better compatibility with complex third-party types.
diff --git a/docs/zh-CN/guide/how-it-works.md b/docs/zh-CN/guide/how-it-works.md
@@ -33,12 +33,12 @@ tsdown 读取你的 `package.json` 和 `tsconfig.json` 来推断合理的默认
 
 **主要选项：**
 
-| 选项                                                                                 | 说明                                                                                                       |
-| ------------------------------------------------------------------------------------ | ---------------------------------------------------------------------------------------------------------- |
-| [`deps.onlyBundle`](../options/dependencies.md#deps-onlybundle)                      | 允许打包的依赖白名单。任何不在列表中的依赖如果出现在 bundle 中将触发错误。适用于防止大型项目中的意外内联。 |
-| [`deps.neverBundle`](../options/dependencies.md#deps-neverbundle)                    | 显式将额外的包标记为外部依赖（不打包）。                                                                   |
-| [`deps.alwaysBundle`](../options/dependencies.md#deps-alwaysbundle)                  | 强制打包特定的包，即使它们在 `dependencies` 中。                                                           |
-| [`deps.skipNodeModulesBundle`](../options/dependencies.md#deps-skipnodemodulebundle) | 跳过解析和打包所有来自 `node_modules` 的内容。                                                             |
+| 选项                                                                                  | 说明                                                                                                       |
+| ------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------------------------------- |
+| [`deps.onlyBundle`](../options/dependencies.md#deps-onlybundle)                       | 允许打包的依赖白名单。任何不在列表中的依赖如果出现在 bundle 中将触发错误。适用于防止大型项目中的意外内联。 |
+| [`deps.neverBundle`](../options/dependencies.md#deps-neverbundle)                     | 显式将额外的包标记为外部依赖（不打包）。                                                                   |
+| [`deps.alwaysBundle`](../options/dependencies.md#deps-alwaysbundle)                   | 强制打包特定的包，即使它们在 `dependencies` 中。                                                           |
+| [`deps.skipNodeModulesBundle`](../options/dependencies.md#deps-skipnodemodulesbundle) | 跳过打包所有来自 `node_modules` 的内容。                                                                   |
 
 详见[依赖](../options/dependencies.md)。
 
diff --git a/docs/zh-CN/options/dependencies.md b/docs/zh-CN/options/dependencies.md
@@ -38,7 +38,7 @@ export default defineConfig({
 
 ### `deps.skipNodeModulesBundle`
 
-如果您希望**跳过解析和打包所有来自 `node_modules` 的依赖**，可以启用 `skipNodeModulesBundle`：
+如果您希望**跳过打包所有来自 `node_modules` 的依赖**，可以启用 `skipNodeModulesBundle`：
 
 ```ts [tsdown.config.ts]
 import { defineConfig } from 'tsdown'
@@ -50,7 +50,7 @@ export default defineConfig({
 })
 ```
 
-这样，无论您的代码如何引用，`tsdown` 都不会解析或打包任何来自 `node_modules` 的依赖。
+这样，无论您的代码如何引用，`tsdown` 都不会打包任何来自 `node_modules` 的依赖。
 
 ::: warning
 `skipNodeModulesBundle` 不能与 `alwaysBundle` 一起使用，这两个选项互斥。
@@ -155,7 +155,7 @@ export default defineConfig({
   - 使用 `deps.onlyBundle` 设置允许被打包的依赖白名单，不在列表中的依赖会触发错误。
   - 使用 `deps.neverBundle` 将特定依赖标记为外部依赖。
   - 使用 `deps.alwaysBundle` 强制将特定依赖打包。
-  - 使用 `deps.skipNodeModulesBundle` 跳过解析和打包所有来自 `node_modules` 的依赖。
+  - 使用 `deps.skipNodeModulesBundle` 跳过打包所有来自 `node_modules` 的依赖。
 - **声明文件**：
   - 声明文件的打包逻辑与 JavaScript 保持一致。
   - 使用 `resolver: 'tsc'` 可提升复杂第三方类型的兼容性。
diff --git a/skills/tsdown/references/option-dependencies.md b/skills/tsdown/references/option-dependencies.md
@@ -98,7 +98,7 @@ export default defineConfig({
 
 ### `deps.skipNodeModulesBundle`
 
-Skip resolving and bundling ALL node_modules:
+Skip bundling ALL node_modules:
 
 ```ts
 export default defineConfig({
@@ -109,7 +109,7 @@ export default defineConfig({
 })
 ```
 
-**Result:** No dependencies from node_modules are parsed or bundled.
+**Result:** No dependencies from node_modules are bundled.
 
 **Note:** Cannot be used together with `alwaysBundle`.
 
diff --git a/src/features/deps.ts b/src/features/deps.ts
@@ -309,7 +309,8 @@ export function DepsPlugin(
       resolved &&
       (resolved.external || RE_NODE_MODULES.test(resolved.id))
     ) {
-      return true
+      const resolvedDep = await resolveDepSubpath(id, resolved)
+      return resolvedDep ? [true, resolvedDep] : true
     }
 
     if (deps) {
diff --git a/tests/__snapshots__/resolve-dep-subpath-without-exports-field/skipNodeModulesBundle-dep-file-should-resolve-to-dep-file-js.snap.md b/tests/__snapshots__/resolve-dep-subpath-without-exports-field/skipNodeModulesBundle-dep-file-should-resolve-to-dep-file-js.snap.md
@@ -0,0 +1,7 @@
+## index.mjs
+
+```mjs
+import { lt } from "my-dep/functions/lt.js";
+export { lt };
+
+```
diff --git a/tests/__snapshots__/resolve-dep-subpath-without-exports-field/skipNodeModulesBundle-dep-folder-should-resolve-to-dep-folder-index-js.snap.md b/tests/__snapshots__/resolve-dep-subpath-without-exports-field/skipNodeModulesBundle-dep-folder-should-resolve-to-dep-folder-index-js.snap.md
@@ -0,0 +1,7 @@
+## index.mjs
+
+```mjs
+import { folder } from "my-dep/folder/index.js";
+export { folder };
+
+```
diff --git a/tests/e2e.test.ts b/tests/e2e.test.ts
@@ -1032,6 +1032,64 @@ describe('resolve dep subpath without exports field', () => {
 
     expect(fileMap['index.mjs']).toContain('my-dep/folder/index.js')
   })
+
+  test('skipNodeModulesBundle dep/file should resolve to dep/file.js', async (context) => {
+    const node_modules = {
+      'node_modules/my-dep/package.json': JSON.stringify({
+        name: 'my-dep',
+        version: '1.0.0',
+        main: 'index.js',
+      }),
+      'node_modules/my-dep/index.js': `export const main = 1`,
+      'node_modules/my-dep/functions/lt.js': `export const lt = () => {}`,
+    }
+
+    const { fileMap } = await testBuild({
+      context,
+      files: {
+        ...node_modules,
+        'index.ts': `export { lt } from 'my-dep/functions/lt'`,
+        'package.json': JSON.stringify({
+          name: 'test-pkg',
+          version: '1.0.0',
+        }),
+      },
+      options: {
+        deps: { skipNodeModulesBundle: true },
+      },
+    })
+
+    expect(fileMap['index.mjs']).toContain('my-dep/functions/lt.js')
+  })
+
+  test('skipNodeModulesBundle dep/folder should resolve to dep/folder/index.js', async (context) => {
+    const node_modules = {
+      'node_modules/my-dep/package.json': JSON.stringify({
+        name: 'my-dep',
+        version: '1.0.0',
+        main: 'index.js',
+      }),
+      'node_modules/my-dep/index.js': `export const main = 1`,
+      'node_modules/my-dep/folder/index.js': `export const folder = 42`,
+    }
+
+    const { fileMap } = await testBuild({
+      context,
+      files: {
+        ...node_modules,
+        'index.ts': `export { folder } from 'my-dep/folder'`,
+        'package.json': JSON.stringify({
+          name: 'test-pkg',
+          version: '1.0.0',
+        }),
+      },
+      options: {
+        deps: { skipNodeModulesBundle: true },
+      },
+    })
+
+    expect(fileMap['index.mjs']).toContain('my-dep/folder/index.js')
+  })
 })
 
 test('.node file bundle', async (context) => {

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,8 @@ export function DepsPlugin(`
`309`	`309`	`resolved &&`
`310`	`310`	`(resolved.external \|\| RE_NODE_MODULES.test(resolved.id))`
`311`	`311`	`) {`
`312`		`- return true`
	`312`	`+ const resolvedDep = await resolveDepSubpath(id, resolved)`
	`313`	`+ return resolvedDep ? [true, resolvedDep] : true`
`313`	`314`	`}`
`314`	`315`
`315`	`316`	`if (deps) {`