Conversation
When shims: true is enabled, tsdown injects ESM shims (__filename, __dirname) by importing from its own esm-shims.js. Since this file resides in node_modules/tsdown/, the dependency detection in generateBundle incorrectly flags tsdown itself as a bundled dependency and shows a confusing hint suggesting the user configure deps.onlyBundle. Skip the shimFile when iterating module IDs in the generateBundle handler so the shim import is not reported as a bundled dependency. Closes #907
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
shims: trueis enabled, tsdown injects ESM shims (__filename,__dirname) by importing from its ownesm-shims.js. Since this file resides innode_modules/tsdown/, the dependency detection ingenerateBundleincorrectly flagstsdownas a bundled dependency and shows a confusing hint. This PR skips theshimFilewhen iterating module IDs so the shim import is not reported.Linked Issues
Closes #907
Additional context
The
shimFilewas already excluded inexternalStrategy()during theresolveIdphase, but thegenerateBundlehook runs independently and was missing the same filter.