[win] Fix build and tests with winrtdebug=ON#19404
Merged
bellenot merged 6 commits intoroot-project:masterfrom Jul 18, 2025
Merged
[win] Fix build and tests with winrtdebug=ON#19404bellenot merged 6 commits intoroot-project:masterfrom
bellenot merged 6 commits intoroot-project:masterfrom
Conversation
- Add the -RTC1 (runtime check) compiler flag with winrtdebug=ON and dev=ON - Add the -D_ITERATOR_DEBUG_LEVEL=0 flag where needed, to work-around the issue with STL iterators and I/O. This produce incompatible debug binaries, but allows to debug ROOT - Add the LLVM_ENABLE_DUMP=TRUE option when LLVM_BUILD_TYPE is Debug or RelWithDebInfo - Fix gtest-tree-ntuple-ntuple-packing, which was failing for one bit difference
bellenot
requested review from
couet,
dpiparo,
jblomer and
pcanal
as code owners
vgvassilev
approved these changes
Jul 18, 2025
Member
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
I used this patch and it worked for me. Looks good, given the minor comment.
Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
bellenot
commented
Jul 18, 2025
bellenot
commented
Jul 18, 2025
bellenot
commented
Jul 18, 2025
pcanal
reviewed
Jul 18, 2025
bellenot
requested review from
pcanal
and removed request for
couet,
jblomer and
silverweed
martinfoell
pushed a commit
to martinfoell/root
that referenced
this pull request
Oct 9, 2025
* [win] Fix build and tests with winrtdebug=ON - Add the -RTC1 (runtime check) compiler flag with winrtdebug=ON and dev=ON - Add the -D_ITERATOR_DEBUG_LEVEL=0 flag where needed, to work-around the issue with STL iterators and I/O. This produce incompatible debug binaries, but allows to debug ROOT - Add the LLVM_ENABLE_DUMP=TRUE option when LLVM_BUILD_TYPE is Debug or RelWithDebInfo - Fix gtest-tree-ntuple-ntuple-packing, which was failing for one bit difference * Update interpreter/CMakeLists.txt Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com> * Update interpreter/CMakeLists.txt * Update interpreter/CMakeLists.txt * Revert changes in tree/ntuple/src/RColumnElement.hxx * debug and optimized are exclusive on Windows only --------- Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-RTC1(runtime check) compiler flag withwinrtdebug=ONanddev=ON-D_ITERATOR_DEBUG_LEVEL=0flag where needed, to work-around the issue with STL iterators and I/O. This produce incompatible debug binaries, but allows to debug ROOTLLVM_ENABLE_DUMP=TRUEoption whenLLVM_BUILD_TYPEisDebugorRelWithDebInfo