[cppyy] fix: instantiation of templated functions#19450
Merged
Vipul-Cariappa merged 1 commit intoroot-project:masterfrom Jul 28, 2025
Merged
[cppyy] fix: instantiation of templated functions#19450Vipul-Cariappa merged 1 commit intoroot-project:masterfrom
Vipul-Cariappa merged 1 commit intoroot-project:masterfrom
Conversation
Contributor
Author
|
@siliataider, @vepadulano, You might be interested in this. |
vgvassilev
reviewed
Jul 23, 2025
Member
|
Very nice. @Vipul-Cariappa would you mind perhaps adding a test? |
Test Results 21 files 21 suites 3d 8h 56m 57s ⏱️ Results for commit 52a7437. ♻️ This comment has been updated with latest results. |
Vipul-Cariappa
force-pushed
the
fix/TemplateProxy-NonInit-ToStr
branch
from
dfbe8ab to
8e00338
Compare
Contributor
Author
|
Done.
…On Wed, Jul 23, 2025 at 9:35 PM Danilo Piparo ***@***.***> wrote:
*dpiparo* left a comment (root-project/root#19450)
<#19450 (comment)>
Very nice. @Vipul-Cariappa <https://github.com/Vipul-Cariappa> would you
mind perhaps adding a test?
—
Reply to this email directly, view it on GitHub
<#19450 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANI5JBO57FYSLS35HWWVIHD3J7PYFAVCNFSM6AAAAACCGDYPP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMBZHA4TGMJXHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
vepadulano
requested changes
Jul 24, 2025
Vipul-Cariappa
force-pushed
the
fix/TemplateProxy-NonInit-ToStr
branch
2 times, most recently
from
6f6bf91 to
db169ce
Compare
when instantiating with another templated function
Vipul-Cariappa
force-pushed
the
fix/TemplateProxy-NonInit-ToStr
branch
from
db169ce to
52a7437
Compare
vgvassilev
reviewed
Jul 28, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When instantiating with another templated function