GDML fixes #10044
Merged
GDML fixes #10044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting build on |
|
I don't know enough about the CI to know what's causing this problem. @agheata, could you take a look? Can I help? |
Member
Author
|
Can someone from the team review/merge this? |
pcanal
approved these changes
Apr 1, 2022
Member
pcanal
left a comment
pcanal
left a comment
There was a problem hiding this comment.
Looks good. Consider applying the clang format suggestions: https://github.com/root-project/root/runs/5413964125?check_suite_focus=true
Neel-Shah-29
pushed a commit
to Neel-Shah-29/root-1
that referenced
this pull request
Apr 6, 2022
* Emit error messages when parsing undefined gdml names. * Correct handling when written gdml node not matching top one. * Cleaning TGeoManager instance in case of gdml import failure. * Correctly mark inverse transformations as not registered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Fixes validity of exported gdml file when the exported node is not the top geometry node. Adds error messages on gdml import errors, and deletes geometry manager in such case.
Checklist:
This PR fixes #9310