Skip to content

update xrootd hash #11106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2022
Merged

update xrootd hash #11106

merged 1 commit into from
Aug 3, 2022

Conversation

@lmoneta
Copy link
Member

@lmoneta lmoneta commented Aug 3, 2022

No description provided.

@lmoneta lmoneta requested a review from bellenot as a code owner August 3, 2022 15:13
@phsft-bot
Copy link

phsft-bot commented Aug 3, 2022

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

@lmoneta lmoneta force-pushed the update_xrootd_hash branch from d5baf0d to f6a6878 Compare August 3, 2022 15:26
@phsft-bot
Copy link

phsft-bot commented Aug 3, 2022

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

@lmoneta lmoneta merged commit ce4ca3e into root-project:master Aug 3, 2022
@pcanal
Copy link
Member

pcanal commented Aug 3, 2022 •
edited
Loading

Why did the hash of the file in lcgpackage change even-though the xrootd version did not change? (i.e. Didn't we migrate away from downloading from github to avoid exactly this kind of problem?)

pcanal pushed a commit to pcanal/root that referenced this pull request Aug 3, 2022
@lmoneta @pcanal
[cmake] Update xrootd hash after a new version of the xrootd tar file (…
0d9c6c7 
…root-project#11106)
@pcanal pcanal mentioned this pull request Aug 3, 2022
Merged
bellenot pushed a commit that referenced this pull request Aug 4, 2022
@lmoneta @bellenot
[cmake] Update xrootd hash after a new version of the xrootd tar file (…
0c9a4e6 
…#11106)
@bellenot
Copy link
Member

bellenot commented Aug 4, 2022

Why did the hash of the file in lcgpackage change even-though the xrootd version did not change? (i.e. Didn't we migrate away from downloading from github to avoid exactly this kind of problem?)

That's a good question! I asked some people here, we'll see...

@bellenot
Copy link
Member

bellenot commented Aug 4, 2022

OK, problem understood. The person who did the change came to my office, that should never happen again (hopefully).

@pcanal
Copy link
Member

pcanal commented Aug 4, 2022

Thanks.

bellenot added a commit to bellenot/root that referenced this pull request Aug 10, 2022
@bellenot
Revert "[cmake] Update xrootd hash after a new version of the xrootd …
26c2609 
…tar file (root-project#11106)"

This reverts commit ce4ca3e.
@bellenot bellenot mentioned this pull request Aug 10, 2022
Merged
bellenot added a commit to bellenot/root that referenced this pull request Aug 10, 2022
@bellenot
[v6-26] Revert "[cmake] Update xrootd hash after a new version of the…
530d6e0 
… xrootd tar file (root-project#11106)"

This reverts commit 0c9a4e6.
@bellenot bellenot mentioned this pull request Aug 10, 2022
Merged
bellenot added a commit that referenced this pull request Aug 10, 2022
@bellenot
Revert "[cmake] Update xrootd hash after a new version of the xrootd …
23b361c 
…tar file (#11106)"

This reverts commit ce4ca3e.
bellenot added a commit that referenced this pull request Aug 10, 2022
@bellenot
[v6-26] Revert "[cmake] Update xrootd hash after a new version of the…
9ee0304 
… xrootd tar file (#11106)"

This reverts commit 0c9a4e6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bellenot bellenot bellenot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lmoneta @phsft-bot @pcanal @bellenot