Skip to content

Conversation

linev
Copy link
Member

@linev linev commented Jul 18, 2023

Implement proper handling of canvas window size and canvas drawing area size.

By default web browser with given window size/position will be started. Depending from context menu,
status line, other layout components drawing area will be reduced to some value and always adjust to that area.

With the call TCanvas::SetCanvasSize(width,height) one can fix drawing area to exact value, which does not change with web browser resize. One can toggle state either with context menu or by calling ``c1->SetCanvasSize(0,0)`.

All browser window position/size changes are reflected in the TCanvas members

Provide JSROOT with new resize logic, also includes support of TLatex in 3D plots

linev added 5 commits July 17, 2023 10:58
Not only canvas pixel size, but also browser window size
is now received from the client. It is stored in fWindowGeometry
vector, which indicates last receieved geometry from the client
It lets configure fixed pixel size of canvas drawing, which
then propagated to client. On the client there is menu item which allow
to toggle auto-resize flag.
Just configure top HTML element to have fixed geometry or adjust content
to widget sizes. Inform canvas painter if changing flag via context menu
Main parameters are window position and size,
canvas sizes fCw and fCh are derived and depends from actual rendering
Plus latex support in 3D and "bare1" draw option for TH1
@sonatype-lift
Copy link

sonatype-lift bot commented Jul 18, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

Let select file name like in OpenFile dialog
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14
How to customize builds

@linev linev merged commit f0cc453 into root-project:master Jul 18, 2023
@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on mac11/noimt.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

@linev linev deleted the webcan_windowsize branch July 19, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants