-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update THStack documentation #15766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update THStack documentation #15766
Conversation
How it is done? Currently I see no protection for negative bins content. |
Test Results 11 files 11 suites 2d 12h 14m 46s ⏱️ Results for commit a76d35a. ♻️ This comment has been updated with latest results. |
In Add: |
|
Any way this PR make several test fail like "tutorial-legacy-mlp-mlpRegression" let see what @moneta think about it. |
|
It seems OK now |
linev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One should change Warning method name.
* Update THStack documentation * Only issue a warning in case of negative histogram in a stack * Change the method name in the Warning call.
* Update THStack documentation * Only issue a warning in case of negative histogram in a stack * Change the method name in the Warning call.
* Update THStack documentation * Only issue a warning in case of negative histogram in a stack * Change the method name in the Warning call.
As said in this old forum post https://root-forum.cern.ch/t/thstack-th2-with-negative-values/16161/5, stacking a histogram with negative bin content does not make sense. This issue is not relevant #15740. But it is goo to make it clear in the documentation and to prevent adding such histograms in a stack. That's what this PR is doing.