Enable CppInterOp #16296
Closed
Enable CppInterOp #16296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CppInterOp](https://github.com/compiler-research/CppInterOp) exposes API from Clang and LLVM in a mostly backward compatibe way. The API support downstream tools that utilize interactive C++ by using the compiler as a service. Adopting more of CppInterOp in ROOT will help simplify the LLVM migration process and allow us to upstream more patches to either CppInterOp or LLVM.
vgvassilev
force-pushed
the
enable-cppinterop
branch
from
f18ddc5 to
937a30b
Compare
|
Note that if we want to download at configuration time we should use FetchContent_Declare which seems to take similar arguments. |
hahnjo
reviewed
Aug 23, 2024
core/metacling/src/CMakeLists.txt
Outdated
| list(APPEND _cppinterop_extra_cmake_args -DCMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD}) | ||
| endif(CMAKE_CXX_STANDARD) | ||
|
|
||
| if (LLVM_FORCE_USE_OLD_TOOLCHAIN) |
There was a problem hiding this comment.
This is defined in interpreter/CMakeLists.txt, so very likely we cannot access it here...
There was a problem hiding this comment.
Dropped as we shouldn't need this as we build InterOp with clang>6 and hence gcc>=7.1
|
Note that we need to land compiler-research/CppInterOp#318, release and then merge this PR. |
Test Results 13 files 13 suites 2d 16h 36m 3s ⏱️ Results for commit 8cbe14e. |
|
Closing in favor or #16814. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CppInterOp exposes API from Clang and LLVM in a mostly backward compatibe way. The API support downstream tools that utilize interactive C++ by using the compiler as a service.
Adopting more of CppInterOp in ROOT will help simplify the LLVM migration process and allow us to upstream more patches to either CppInterOp or LLVM.
@aaronj0, you can take it from here.