[Python] Avoid using std::regex in CPyCppyy
#17364
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `std::regex` in CPyCppyy leads to problems in conjunction with XGBoost and PyTorch. We could previously work around these issues by importing these libraries before ROOT, but there still seem to be problems remaining as we see in the CppInterop PR. This commit tries to revert the introduction of `std::regex` in CPyCppyy and the import order hack, to see if this would also work. wlav/CPyCppyy@c437364950cafe06 For ROOTs CPyCppyy, `std::regex` was only introduced with the syncup in ROOT 6.32. Therefore, reverting back to the previous algorithm without `std::regex` should not affect our uses.
Test Results 17 files 17 suites 4d 4h 31m 1s ⏱️ For more details on these failures, see this check. Results for commit 18b8bef. |
|
Didn't help in the CppInterOp PR, so not worth doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
std::regexin CPyCppyy leads to problems in conjunction with XGBoost and PyTorch. We could previously work around these issues by importing these libraries before ROOT, but there still seem to be problems remaining as we see in the CppInterop PR.This commit tries to revert the introduction of
std::regexin CPyCppyy and the import order hack, to see if this would also work.wlav/CPyCppyy@c437364950cafe06
For ROOTs CPyCppyy,
std::regexwas only introduced with the syncup in ROOT 6.32. Therefore, reverting back to the previous algorithm withoutstd::regexshould not affect our uses.