[Python][RF] Introduce Klass::contains -> Klass.__contains__ pythonization and use it in RooFit
#19999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As ROOT requires C++17 for a long time now, cppyy also requires it and we can remove the checks for C++17 or lower standards from the code.
This mimics what is done in the newer C++ standards for multiple standard library classes, and also tells cppyy how to implement `__contains__` in the Python proxy.
This is to make all overloads for looking up elements available via the `contains()` pythonization.
The newer C++ standards already implement a `contains()` method for multiple STL classes. We can just forward to these in the `__contains__` method for the Python proxy. Forwarding to `contains()` on the C++ side means also that it will become easier to implement classes that Pythonize nicely automatically. Just as happened already before with `size()` (that got used to automatically implement `__len__`), one just needs to implement `contains()` on the C++ side now to implicitly get the `__contains__` pythonization.
guitargeek
force-pushed
the
issue-19986
branch
from
172c49c to
3baa681
Compare
Test Results 22 files 22 suites 3d 15h 49m 7s ⏱️ Results for commit 3baa681. |
aaronj0
approved these changes
Sep 30, 2025
Contributor
aaronj0
left a comment
aaronj0
left a comment
There was a problem hiding this comment.
The changes on the cppyy side look good to me! Thanks for this improvement in the contains() pythonizations utilizing the C++ implementation
Contributor
Author
|
Thanks for the review! As the change to RooFit was also seen as useful and intuitive by @AlkaidCheng who opened the issue, I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by the existing
Klass::size->Klass.__len__pythonization, lifting another STL-typical C++ method to a magic Python method for the sake of Pythonization.This PR enables for example checking for the existence of a specific snapshot in a RooWorkspace.
Test coverage is provided by the cppyy unit tests.
Closes #19986.